[Due for payment 2026-07-03] Rules - "1 selected" dropdown button persists after deleting the rule

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.4.17-2
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #93185
Email or phone of affected tester (no customers): applausetester+ssndjois2jd1@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Paste Onyx.merge('betas', ['rulesRevamp']); in console.
• Enable Rules.
• Create an expense default in Rules > Add rule > Apply expense defaults.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Rules.
3. Go to Expense defaults.
4. Select the rule via checkbox.
5. Click on the rule.
6. Click Delete rule > Delete.

Expected Result:

"1 selected" dropdown button will disappear after deleting the rule.

Actual Result:

"1 selected" dropdown button persists after deleting the rule.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

Bug7188827_1782227594591.31.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7188827

Issue Owner

Current Issue Owner: @Krishna2323

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/16fdd14598fd219d285192928e75482d467d81fa3188d671ea5a90d5db77604b

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #93185

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Proposal

Problem

After selecting an Expense default rule via its checkbox, opening that rule, and deleting it from the rule detail page, the "1 selected" bulk-actions dropdown stays visible even though the selected rule no longer exists.

Root Cause

The selected-row state in PolicyRulesPageRevamp.tsx (selectedExpenseDefaultKeys / selectedSpendRuleKeys) is only ever cleared in two places: the bulk delete action (deleteSelectedExpenseDefaults → clearTableSelection) and tab switches.

The repro path deletes the rule from the individual rule detail page, not via the bulk action, so clearTableSelection() never runs. The stale ruleID remains in selectedExpenseDefaultKeys, and since the dropdown is driven purely by selectedRuleKeys.length, the "1 selected" button persists. Selection is reconciled against the live table data only inside the handleExpenseDefaultSelectionChange/handleSpendRuleSelectionChange handlers, which fire on checkbox toggles — not when the underlying codingRules data changes out from under the page.

Recommended Fix

Reconcile the selected keys whenever the table data changes — prune any selected key that is no longer present in the current rows. Add an effect in PolicyRulesPageRevamp.tsx that filters both selection states against the live data, e.g.:

// Drop selected keys whose rules no longer exist (e.g. deleted from the rule detail page)
useEffect(() => {
    const validExpenseDefaultKeys = new Set(expenseDefaultsTableData.map((rule) => rule.keyForList));
    setSelectedExpenseDefaultKeys((prev) => prev.filter((key) => validExpenseDefaultKeys.has(key)));
}, [expenseDefaultsTableData]);

useEffect(() => {
    const validSpendRuleKeys = new Set(spendRulesTableData.map((rule) => rule.keyForList));
    setSelectedSpendRuleKeys((prev) => prev.filter((key) => validSpendRuleKeys.has(key)));
}, [spendRulesTableData]);

This also fixes the equivalent case on the Card restrictions tab, which has the same single-rule-delete path.

Investigation details & alternatives considered

• The bulk delete flow correctly clears selection, which is why deleting via the "1 selected" → Delete dropdown does not reproduce the bug — only the detail-page delete does.
• Alternative considered: clearing selection from inside the rule detail page's delete handler. Rejected — the detail page would need to reach back into the parent's selection state, and it wouldn't cover other ways rows can disappear (search/filter, server-side updates). Reconciling against the live data in the parent is the more robust, single source of truth.
• Confidence: High — code evidence is complete (input → stale state → persisted UI), and the fix matches the scope of the bug.

---

Next Steps for Contributor+ team:
To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/94353) to create a draft PR.
To refine: @MelvinBot <your feedback>
To reject: Explain why you are rejecting Melvin's proposal.

[JS00001]

Behind a beta