[Due for payment 2026-07-03] Rules - Select all checkbox shows a hand cursor when the checkbox is not clickable

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.4.17-2
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #93185
Email or phone of affected tester (no customers): applausetester+ssndjois2jd1@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Paste Onyx.merge('betas', ['rulesRevamp']); in console.
• Enable Expensify card and set it up with bank account.
• Enable Rules.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Rules.
3. Go to Card restrictions.
4. Click Select all checkbox.

Expected Result:

Select all checkbox should have a disabled cursor when the checkbox is not clickable.

Actual Result:

Select all checkbox shows a hand cursor when the checkbox is not clickable.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

Bug7188823_1782227350339.30.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7188823

Issue Owner

Current Issue Owner: @Krishna2323

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/f88d817cc207b8ec11e3734e487de7b39820cea104564f0fba2e034f6a946ab6

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #93185

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Proposal

What is the root cause of that problem?

The "Select all" checkbox in the table header is never given a disabled prop, so it always renders the pointer (hand) cursor — even when there are no selectable rows to act on.

On the Card restrictions tab, the table always contains the built-in default protection rule, which is hard-coded as a disabled row (PolicyRulesPageRevamp.tsx:156). When a workspace has no custom card rules yet, that default rule is the only row, so the set of selectable rows is empty.

In the header, selectableRows excludes disabled rows, but the select-all Checkbox is rendered without a disabled prop in both layouts (TableHeader.tsx:110-118 and TableHeader.tsx:134-139). Clicking it is a no-op when there are no selectable rows (selection.ts:101), yet the cursor still says it's clickable.

Evidence chain

1. defaultSpendRule has disabled: true and is always prepended to spendRulesTableData.
2. With no custom rules, every row in the Card restrictions table is disabled → selectableRows is empty.
3. The header Checkbox has no disabled prop, so SelectionButton never applies styles.cursorDisabled and GenericPressable falls through to styles.cursorPointer.
4. handleSelectAll resolves to onRowSelectionChange([]) (a no-op) when selectableKeys is empty → the checkbox is visually clickable but does nothing.

What changes do you think we should make in order to solve the problem?

In src/components/Table/TableHeader.tsx, pass a disabled prop to both select-all Checkbox instances (narrow and wide layouts), set to true when there are no selectable rows (i.e. selectableRows.length === 0).

SelectionButton already applies styles.cursorDisabled and styles.buttonOpacityDisabled when disabled is set, so this fixes the cursor and gives the expected disabled affordance with no further changes. This is also the correct general behavior for any table whose only rows are disabled, not just Card restrictions.

What alternative solutions did you explore? (Optional)

None needed — the header already computes selectableRows; the fix simply wires that into the checkbox's disabled state.

---

Next Steps for Contributor+ team:
To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/94352) to create a draft PR.
To refine: @MelvinBot <your feedback>
To reject: Explain why you are rejecting Melvin's proposal.

[blimpich]

Demoted: https://expensify.slack.com/archives/C01GTK53T8Q/p1782240289128309?thread_ts=1782239911.378619&cid=C01GTK53T8Q