Spend filters - Card feed selector is missing in Card list

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.4.5-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #91806
Email or phone of affected tester (no customers): applausetester+khcategory19@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Search

Action Performed:

Precondition:

• Account has at least one Expensify card or company card.

1. Go to staging.new.expensify.com
2. Go to Spend > Expenses.
3. Open Filters.
4. Open Card.

Expected Result:

Card feed selector will be present in Card list.

Actual Result:

Card feed selector is missing in Card list.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

Bug7177435_1781136052582.11.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7177435

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/78eb05a1ba578fc36b0b80e1a48d3011753c1f15a61d7b5f280ba0d283550743

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #91806

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Opening Spend → Expenses → Filters → Card no longer shows the card feed selector (the "Card feeds" section). Only individual/closed cards appear. Regression from #91806 (reproducible on staging, not production).

What is the root cause of that problem?

PR #91806 replaced the dedicated card-filter page with the new popover flow, and the new CardSelector component does not build the card-feeds section that the old page rendered.

• Old card page built three sections — Card feeds (via buildCardFeedsData), Individual cards, Closed cards: SearchFiltersCardPage.tsx:89-108. That page is now orphaned — its navigation entry was removed; only individual + closed cards are built in the popover's CardSelector.tsx:82-98.
• Instead, the PR split feeds into a new top-level "Feed" filter (useAdvancedSearchFilters.ts:41-42) backed by FeedSelector (FilterComponents/index.tsx:139-147).

So the feeds were moved to a separate "Feed" filter row, not deleted — but they no longer appear inside the Card filter, which is what the test was checking.

Why this needs a product/design decision

The split looks intentional (the PR deliberately added the FEED row and wired FeedSelector). The question is whether feeds should still live inside the Card list or are now expected to live under their own Feed filter.

• The orphaned SearchFiltersCardPage.tsx and its still-registered screen ModalStackNavigators/index.tsx:1242 are now dead code and should be removed if the split is the intended end state.

What changes do you think we should make in order to solve the problem?

Confirm intended design, then either:

• If feeds are intentionally a separate "Feed" filter (likely): this is expected behavior — verify the new Feed filter row appears and works, and update the QA/regression expectation. Also delete the now-orphaned SearchFiltersCardPage and its ADVANCED_FILTERS_CARD_RHP screen registration.
• If feeds should stay in the Card list: add the card-feeds section back into CardSelector.tsx by building buildCardFeedsData(...) and prepending a search.filters.card.cardFeeds section (mirroring the old page), and update selection/onChange to handle feed rows.

What alternative solutions did you explore?

Re-pointing the Card filter back to the old SearchFiltersCardPage route, but that would undo the popover refactor and is not desirable.

---

Next Steps for Contributor+ team:
To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/93239) to create a draft PR.
To refine: @MelvinBot <your feedback>
To reject: Explain why you are rejecting Melvin's proposal.

[aimane-chnaif]

cc: @bernhardoj

[bernhardoj]

This is expected. Card and feed filter is now separated

[JS00001]

Agreed, this is expected