[Due for payment 2026-07-23 ?] [$250] [Submit] Workspace - Upgrade page reopens after upgrading workspace and importing spreadsheet

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.4.0-2
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #91258
Email or phone of affected tester (no customers): applausetester+sdodjso22ds@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Log in with Expensifail account.
• Create a Control workspace and invite a member as auditor.
• Create a Submit workspace on OD.

1. Go to staging.new.expensify.com
2. Go to Control workspace settings > Members.
3. Click More > Download CSV.
4. Go to Submit workspace settings > Members.
5. Click More > Import spreadsheet.
6. Click Import > Upgrade > Got it, thanks.
7. Click Import again.

Expected Result:

Upgrade page will not appear because the workspace is upgraded before.

Actual Result:

Upgrade page reopens after upgrading workspace and importing spreadsheet.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

Bug7175044_1780930963085.31.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7175044

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022073044725705633999
• Upwork Job ID: 2073044725705633999
• Last Price Increase: 2026-07-03

Issue Owner

Current Issue Owner: @mallenexpensify

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/9a4531d98b831d1e156bcd80d84eec9fb43ee0798010507ab6add4c62ac867cc

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #91258

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On a Submit workspace, importing a member spreadsheet that contains an Auditor role sends the admin to the Upgrade page. After upgrading and importing again, the Upgrade page reopens instead of completing the import, even though the workspace was already upgraded.

What is the root cause of that problem?

The auditor import gate requires a Control policy, but the new Submit-workspace upgrade flow (added in Expensify/App#91258) upgrades to Collect by default — so the gate never passes after upgrade.

Step by step:

1. The import gate redirects to the Upgrade page using the auditor feature whenever the CSV has an auditor role and the policy is not Control — ImportedMembersPage.tsx:103-106.
2. For a Submit workspace, the upgrade calls upgradeSubmit(policy, targetType, …) where targetType = feature.requiredPlan ?? CONST.POLICY.TYPE.TEAM — WorkspaceUpgradePage.tsx:175-178.
3. The auditor feature has no requiredPlan — CONST/index.ts:8013-8020 — unlike rules/perDiem/hr, which set requiredPlan: CORPORATE. So targetType falls back to TEAM (Collect).
4. upgradeSubmit then sets policy.type = targetType = team (Collect) — Policy.ts:5828.
5. On the next import, isControlPolicy(policy) is still false (Collect ≠ Corporate — PolicyUtils.ts:1127-1129), so the same gate re-fires and the Upgrade page reopens.

Why this is a regression from #91258

Before #91258, onUpgradeToCorporate always called upgradeToCorporate(...), which upgrades to Control — so importing auditors landed on a Control policy and the gate passed. The new Submit path routes through upgradeSubmit with a default of TEAM, and because the auditor feature lacks requiredPlan, the workspace lands on Collect, leaving the auditor gate permanently unsatisfied.

What changes do you think we should make in order to solve the problem?

Add a requiredPlan to the auditor feature so the Submit upgrade routes to Control, matching the auditor gate:

auditor: {
    id: 'auditor' as const,
    alias: 'auditor',
    name: 'Auditor',
    title: 'workspace.upgrade.auditor.title' as const,
    description: 'workspace.upgrade.auditor.description' as const,
    icon: 'BlueShield',
    requiredPlan: this.POLICY.TYPE.CORPORATE,
},

This is consistent with the other Control-only features and makes upgradeSubmit pass CORPORATE, so after upgrade isControlPolicy(policy) is true and re-importing proceeds without showing the Upgrade page again.

What alternative solutions did you explore? (Optional)

Alternatively, relax the import gate at ImportedMembersPage.tsx:103 to also accept upgraded Submit (Collect) policies — but that would change the product rule that auditors require Control, so the requiredPlan fix is preferred.

---

Next Steps for Contributor+ team:
To accept: @MelvinBot implement this to create a draft PR.
To refine: @MelvinBot <your feedback>
To reject: Explain why you are rejecting Melvin's proposal.

[iwiznia]

Not a blocker since it's under beta