[Due for payment 2026-06-04] [Due for payment 2026-06-03] Workspace - Accounting row is shown when QBD connection fails

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.83-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #90220
Email or phone of affected tester (no customers): applausetester+ssndjois2jd@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Log in with Expensifail account.
• Create two Control workspaces - A and B.
• Enable Accounting in Workspace A.

1. Go to staging.new.expensify.com
2. Go to Workspace A settings > Accounting.
3. Click Connect QuickBooks Desktop.
4. Click Done.
5. Click app back button to return to workspace list.
6. Click 3-dot menu on Workspace A > Copy settings.
7. Select Workspace B > Continue.

Expected Result:

Accounting row will be hidden when QBD connection fails.

Actual Result:

Accounting row is shwon when QBD connection fails.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

Bug7164142_1779874091500.9.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7164142

Issue Owner

Current Issue Owner: @fedirjh

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/349e9f46843930936b10b8f71a30d39e80ee8785bbea64edb8ba1932109bb905

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #90220

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Proposal

What is the root cause of that problem?

The Copy Policy Settings feature list decides whether to show the "Accounting" row by checking connectedIntegrationCount > 0 (CopyPolicySettingsUtils.ts:205). That count comes from getAllValidConnectedIntegration(), which only excludes connections where isAuthenticationError is true. A QBD connection that failed but did not set lastSync.isAuthenticationError = true (e.g. lastSync is empty or isConnected is false) still passes the filter and is counted as valid.

The same gap exists in getAccountingConnectionIdentity(), which also skips connections only on isAuthenticationError.

What changes do you think we should make in order to solve the problem?

getAllValidConnectedIntegration() in utils.ts:75-79 should additionally exclude connections that are unverified by also checking isConnectionUnverified(). The filter should become:

(integration) => !!policy?.connections?.[integration]
    && !isAuthenticationError(policy, integration)
    && !isConnectionUnverified(policy, integration)

The same fix should be applied to getAccountingConnectionIdentity() in CopyPolicySettingsUtils.ts:113 — add || isConnectionUnverified(policy, connectionName) to the skip condition.

This ensures that any broken/unverified connection (empty lastSync, isConnected === false, or unverified NetSuite/Certinia) is excluded from both the feature visibility check and the compatibility check.

What alternative solutions did you explore?

An alternative would be to check policy.areConnectionsEnabled instead of counting valid connections, mirroring what the main workspace settings page does. However, that would show the Accounting row even when there's no connection data to copy, which isn't desirable for the copy-settings context. The isConnectionUnverified approach is more precise — it reuses existing infrastructure that already handles the various failure modes per connection type.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.