[Due for payment 2026-06-17] Workspace - Missing "1 bank accounts" on Invoice row when workspace has partially setup bank

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.83-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #90220
Email or phone of affected tester (no customers): applausetester+sdjoisjdosd@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Log in with Expensifail account.
• Have at least two workspaces.
• Enable Invoices in one of the workspaces.

1. Go to staging.new.expensify.com
2. Go to Workspaces.
3. Open workspace with invoices enabled.
4. Go to workspace settings > Invoices.
5. Click Add bank account.
6. Click Connect manually.
7. Enter details until Date of birth section, then close the RHP.
8. Return to workspace list.
9. Click 3-dot menu on the workspace with partially setup bank account > Duplicate workspace.
10. Click Next.
    → Invoice row shows "1 bank accounts".
11. Close the RHP.
12. Click 3-dot menu on the same workspace > Copy settings.
13. Select any workspace > Next.

Expected Result:

Invoice row will show "1 bank accounts" when workspace has partially setup bank account, similar to when dupilcating workspace.

Actual Result:

Invoice row does not show "1 bank accounts" when workspace has partially setup bank account.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

Bug7164119_1779871201982.7.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7164119

Issue Owner

Current Issue Owner: @truph01

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/43d8a559f292ef7225e3097e4cdacec61e09b4e7a7427b1433b8c93bc6a77f35

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #90220

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Proposal

What is the root cause of that problem?

The "Copy settings" flow uses stricter logic for the Invoice row's description text than the "Duplicate workspace" flow.

In the Duplicate flow (WorkspaceDuplicateSelectFeaturesForm.tsx:172), the alternateText is: bankAccountList ? "${count} bank accounts, ${invoiceCompany}" : invoiceCompany — it shows the bank count whenever bankAccountList is truthy, regardless of whether invoiceCompany exists.

In the Copy Settings flow (CopyPolicySettingsSelectFeaturesPage.tsx:170), the logic requires both bankCount > 0 AND invoiceCompany to be truthy before showing the combined string. When only bank accounts exist (no invoice company configured), it falls through to return invoiceCompany || undefined, which returns undefined — so no description is shown.

What changes do you think we should make in order to solve the problem?

Update the invoices case in CopyPolicySettingsSelectFeaturesPage.tsx:168-174 to show bank count and invoice company independently, building the string from whichever parts are available:

case 'invoices': {
    const bankCount = bankAccountList ? Object.keys(bankAccountList).length : 0;
    const parts = [];
    if (bankCount > 0) {
        parts.push(`${bankCount} ${translate('common.bankAccounts').toLowerCase()}`);
    }
    if (invoiceCompany) {
        parts.push(invoiceCompany);
    }
    return parts.length > 0 ? parts.join(', ') : undefined;
}

This aligns the Copy Settings behavior with the Duplicate flow while being slightly cleaner (no trailing comma edge case).

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

[truph01]

I don't think this should be considered a blocker since it's a new feature. We can treat it as a follow-up issue.