[$250] Web - Workspace - Added VBA does not show in any of the menu options when accessing offline

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com and login with expensifail account
2. Click avatar > workspace > Connect bank account
3. Add a VBA
4. Go to workspace and click any option (Issue cards, Reimburse expenses, Pay bills etc) and observe
5. Disable internet connection and click the same options

Expected Result:

Step 4 - There should be no flickering before all the cards appear
Step 5 - Should display all the cards

Actual Result:

Step 4 - There's a flash for a moment before cards appear
Step 5 - Connect to bank account appears

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• Desktop App
• Android
• iOS
• mWeb
  Version Number: 1.1.66-0

Reproducible in staging?: Y

Reproducible in production?: No

Email or phone of affected tester (no customers): applausetester++2501mn@applause.expensifail.com / Utest123

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Bug5584635_Recording__28.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause internal team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Julesssss]

I'm not sure I completely agree that this is a bug, but this PR seems the most likely cause. Commenting there.

[Julesssss]

Actually, it could be this PR . Again, I think this is expected behaviour. Will wait for a second opinion before I resolve though.

[kavimuru]

@Julesssss When we access the menu options in the workspace editor while offline we see the button "Connect bank account" for VBA added account. But in production this is not the case.


.

[Julesssss]

Thanks for confirming @kavimuru.

While we may desire to make further improvements (by remembering whether the user has added a card), I still think that it's more of a side effect than a regression that should be reversed.

One way to do this would be to make a similar change to this PR, so that the component doesn't show until we know for certain whether the user has a connected bank account.

[marcaaron]

Not a blocker IMO, but seems like an interesting one to look into at some point. I think the expected behavior would be that if you added a bank account then, yes, we should be updated the UI to reflect that one was added.