[Due for payment 2026-06-09] Wallet - Card name is not populated with display card name

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.74-7
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #89998
Email or phone of affected tester (no customers): sdsdjoijdoisnjodis@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: User Settings

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Account > Wallet.
3. Click Import transactions.
4. Click Card display name and enter name.
5. Click Next.
6. Upload a file.
7. Map Date column.
8. Click Import.
9. Click on the imported card.

Expected Result:

Card name will be populated with display card name from Step 4.

Actual Result:

Card name is not populated with display card name from Step 4.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7155309_1778866620895!fake_transactions-2026-01-16.10_56_55.629.csv

Bug7155309_1778866620898.9.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @ShridharGoel

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #89998

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

Investigation Summary

Classification: Frontend bug
Causing PR: #89998 - "Have CSV-imported cards open the RHP" by @Gonals (High confidence)
Related Issues: None

Recommendation: REVERT

PR #89998 changed CSV-imported cards to navigate to the Personal Card Details RHP instead of a 3-dot menu. The RHP (PersonalCardDetailsHeaderMenu) displays the card name using customCardNames?.[cardID] ?? card?.cardName ?? getDefaultCardName(...), but CSV-imported cards store their display name in card.nameValuePairs.cardTitle (set via buildOptimisticCard in ImportTransactions.ts), not in card.cardName. Reverting PR #89998 will restore the previous behavior where CSV cards showed a 3-dot menu and the card name issue was not surfaced.

Assigned: @Gonals (PR author), @ShridharGoel @chuckdries (approving reviewers)
Labels: DeployBlockerCash kept (frontend App PR caused the issue); DeployBlocker should be removed (no backend fix required)

Details

Evidence

• The issue is only reproducible on staging (new feature, not in production), and PR [Payment due @ShridharGoel] Have CSV-imported cards open the RHP #89998 is confirmed in the staging deploy checklist.
• PR [Payment due @ShridharGoel] Have CSV-imported cards open the RHP #89998 explicitly changes the behavior for CSV-imported cards: before the PR, clicking a CSV card triggered a 3-dot menu (the isCSVCard guard prevented RHP navigation); after the PR, all personal cards including CSV-imported ones now navigate to ROUTES.SETTINGS_WALLET_PERSONAL_CARD_DETAILS.
• The Personal Card Details RHP (PersonalCardDetailsHeaderMenu.tsx, line 75) reads card name as: customCardNames?.[cardID] ?? card?.cardName ?? getDefaultCardName(cardholder?.firstName).
• However, CSV-imported cards have their display name stored in card.nameValuePairs.cardTitle (see buildOptimisticCard in src/libs/actions/ImportTransactions.ts, line 279-281), NOT in card.cardName.
• The PaymentMethodList.tsx list view correctly reads card.nameValuePairs?.cardTitle for CSV cards (line 267), which is why the name appears correctly in the card list — but after navigating into the RHP, the name is lost.

Verification

• Affected files: src/pages/settings/Wallet/PersonalCardDetailsHeaderMenu.tsx, src/pages/settings/Wallet/PersonalCardDetailsPage.tsx, src/pages/settings/Wallet/PaymentMethodList.tsx
• PR [Payment due @ShridharGoel] Have CSV-imported cards open the RHP #89998 modifies all three files directly.
• The PR's stated purpose is specifically to "have CSV-imported cards open the RHP," confirming this is the change that routes users to the broken card name display.

Root Cause

PersonalCardDetailsHeaderMenu uses card?.cardName as the fallback for the card name field. CSV-imported cards are created optimistically with the display name in nameValuePairs.cardTitle rather than in cardName. PR #89998 newly exposed this mismatch by routing CSV card clicks to the RHP for the first time. A forward fix would need to update PersonalCardDetailsHeaderMenu to check card?.nameValuePairs?.cardTitle in addition to (or instead of) card?.cardName when isCSVImportedPersonalCard is true.