Skip to content

[Due for payment 2026-05-20] [No QA] refactor: OptionRowLHN — ErrorBadge + InfoBadge subcomponents #89955

Description

@mountiny

Part of

#89946 — OptionRowLHN compound component decomposition

Step

9 of 12 — depends on #89947 (Provider + context interface). Incorporates intent of #89752 (badges own translation).

What

Two extractions in one PR:

  1. OptionRow.ErrorBadge (ErrorBadge.tsx) — RBR indicator; either an actionBadgeText <Badge error> or a red DotIndicator icon; owns actionBadgeText translation (translate('common.actionBadge.*')); renders nothing when brickRoadIndicator !== ERROR
  2. OptionRow.InfoBadge (InfoBadge.tsx) — GBR indicator; either an actionBadgeText <Badge success> or a green DotIndicator icon; renders nothing when brickRoadIndicator !== INFO

Both read brickRoadIndicator, actionBadge, and environment from RowContext.

Why

Error and info indicators are visually independent and should each own their rendering and translation logic. This also aligns with the intent of the now-superseded #89752.

Acceptance criteria

  • actionBadgeText translation lives inside each badge component, not in OptionRowLHN.tsx
  • brickRoadIndicator branching lives inside each badge component
  • No visible behavior or style changes
Issue OwnerCurrent Issue Owner: @DylanDylann

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions