Skip to content

[Due for payment 2026-05-22] [No QA] refactor: OptionRowLHN — OfflineWrapper + ProductTrainingTooltip split #89949

Description

@mountiny

Part of

#89946 — OptionRowLHN compound component decomposition

Step

3 of 12 — depends on #89947 (Provider + context interface).

What

Two extractions in one PR:

  1. OptionRow.OfflineWrapper (OfflineWithFeedback.tsx) — wraps OfflineWithFeedback; reads pendingAction and allReportErrors from RowContext.meta; renders children
  2. OptionRow.ProductTrainingTooltip (ProductTrainingTooltip.tsx) — split from the existing OptionRowTooltipLayer; switches to a children API (drops the renderChildren render-prop, addressing the intent of #89751)

OptionRowTooltipLayer.tsx is deleted (or reduced to a thin re-export if needed for the transition).

Why

OfflineWithFeedback and the tooltip layer are independent concerns that should not share a file. Dropping renderChildren in favour of children aligns with the "no render-props for static composition" rule.

Acceptance criteria

  • OptionRow.OfflineWrapper accepts children, reads offline data from context
  • OptionRow.ProductTrainingTooltip accepts children, no renderChildren prop
  • OptionRowTooltipLayer file removed or empty re-export
  • No visible behavior changes
Issue OwnerCurrent Issue Owner: @DylanDylann

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions