Agents - App does not show error when creating new agent without name

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.68-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #89547
Email or phone of affected tester (no customers): josdjnosdjionjsdonjisod@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Other

Action Performed:

Precondition:

• Log in with Expensifail account.

1. Go to staging.new.expensify.com
2. Go to Account > Agents.
3. Click New agent.
4. Clear agent name.
5. Click Save.

Expected Result:

App will show error when creating new agent without name.

Actual Result:

App does not show error when creating new agent without name.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7146618_1778110696270.10.mp4

View all open jobs on GitHub

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #89547

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

Investigation Summary

Classification: Frontend bug
Causing PR: #89547 - "feat: [89310] add agents flow" by @NicolasBonet (High confidence)
Related Issues: #89310

Recommendation: REVERT

The validate function introduced in PR #89547 only validates the prompt field and omits any validation for the firstName (agent name) field. Since this is a new feature that only exists on staging and not production, reverting the PR is the cleanest path forward.

Assigned: @NicolasBonet (PR author), @puneetlath (approving reviewer)
Labels: DeployBlockerCash kept (frontend App bug). DeployBlocker label is present but should be removed since this is a frontend-only issue — the fix requires changes in Expensify/App, not the backend.

Detailed Analysis

Evidence

• The issue reports that clearing the agent name and clicking Save shows no error. This is reproducible on staging (version 9.3.68-0) but is not applicable to production because this is a new feature.
• PR feat: [89310] add agents flow #89547 (merged 2026-05-06) introduced the entire AddAgentPage and AddAgentForm, including the validate function.
• The validate function at lines 37-43 of src/pages/settings/Agents/AddAgentPage.tsx checks values[INPUT_IDS.PROMPT].trim() but never validates values[INPUT_IDS.FIRST_NAME]. An empty name passes validation silently.
• PR feat: [89310] add agents flow #89547 is listed in the StagingDeployCash checklist for release 9.3.68-1.

Verification

• Affected file: src/pages/settings/Agents/AddAgentPage.tsx
• PR feat: [89310] add agents flow #89547 created this file from scratch (119 additions, 0 deletions), confirming it is the direct source of the missing validation.
• The form definition in src/types/form/AddAgentForm.ts (also introduced by this PR) defines FIRST_NAME and PROMPT as the two form fields, but only PROMPT is validated.

Root Cause

In AddAgentPage.tsx, the validate function only contains a check for the PROMPT (instructions) field being non-empty after trimming. There is no corresponding check for FIRST_NAME (agent name). As a result, submitting the form with an empty name field passes client-side validation without displaying any error message to the user.