[HOLD #87170]Create - No "Try it out" toolpit displayed while creating first scan expense.

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.61-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #82255
Email or phone of affected tester (no customers): ibellicotest+2250@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Windows 11 / Chrome
App Component: Money Requests

Action Performed:

1. Open the staging.new.expensify.com website.
2. Sign up with a new account.
3. Complete onboarding modal selecting "Track and budget expenses" option.
4. Click on FAB > "Create Expense"
5. When landing on "Scan" tab, note that there is no "Try it out" toolpit encouraging to try scanning first receipt.

Expected Result:

When user starts the "Create Expense" flow for the first time, a "Try iy out" toolpit should appear on "Scan" tab, encouraging the user to scan first receipt.

Actual Result:

When user starts the "Create Expense" flow for the first time and lands on "Scan" tab, no "Try it out" tooplit is visible.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Video.mp4

View all open jobs on GitHub

[melvin-bot]

@Julesssss recently merged #82255, but they are OOO right now, so I'll auto-assign someone else.

[melvin-bot]

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Issue Analysis

Root Cause: The "Try it out" tooltip on the Scan tab is gated behind the NEWDOT_MANAGER_MCTEST beta flag (newDotManagerMcTest). If the tester's account does not have this beta enabled, the tooltip will never appear regardless of other conditions.

Recommended Fix: Verify whether the NEWDOT_MANAGER_MCTEST beta is intentionally required. If this tooltip should appear for all new users (not just beta users), remove the isBetaEnabled(CONST.BETAS.NEWDOT_MANAGER_MCTEST) condition from the shouldShow parameter in IOURequestStartPage.tsx:272.

Investigation details

The tooltip is implemented at src/pages/iou/request/IOURequestStartPage.tsx:269-286 and configured in src/components/ProductTrainingContext/TOOLTIPS.ts:62-69. All of the following conditions must be true for it to display:

1. NEWDOT_MANAGER_MCTEST beta is enabled for the user
2. User hasn't previously dismissed the tooltip or submitted an expense (NVP_DISMISSED_PRODUCT_TRAINING.scanTestTooltip)
3. Scan tab is the active tab
4. User is not offline on web
5. User is not in a paid policy
6. User is not in the nudge migration
7. Onboarding is completed
8. App is fully loaded
9. No higher-priority tooltip is active (this tooltip has priority 900, lower than most others)

The most likely cause is condition #1 — the beta flag. A new staging account created during testing would only have this beta if it's been rolled out to staging. Other possible blockers are condition #5 (paid policy) or condition #9 (another tooltip with higher priority taking precedence).

Note: There is a related open issue to remove this tooltip entirely: #87170 ("Remove SCAN_TEST_TOOLTIP from Create Expense Scan flow"). If that removal is the intended direction, this bug may be moot.

---

Next Steps: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.

[OSBotify]

🔍 Investigation Summary

Classification: Frontend bug
Causing PR: #82255 - "Resolve @ts-expect-error comments related to OnyxUpdate changes - first batch" by @OlGierd03 (Medium confidence)
Related Issues: None

Recommendation: NEEDS INVESTIGATION

The "Try it out" tooltip on the Scan tab is gated behind isBetaEnabled(CONST.BETAS.NEWDOT_MANAGER_MCTEST) in IOURequestStartPage.tsx line 272. The test account (ibellicotest+2250@gmail.com) likely does not have this beta enabled, which explains why the tooltip never appears. PR #82255 did not change this beta gate condition — it was already in place before this PR.

However, PR #82255 was the PR being QA'd when the issue was reported, and the QA test steps in that PR explicitly call for verifying this tooltip. The PR did change how the NVP_DISMISSED_PRODUCT_TRAINING[SCAN_TEST_TOOLTIP] value is stored during expense creation (from a plain timestamp string to {timestamp, dismissedMethod: 'click'}), but this change is scoped to the isMoneyRequestToManagerMcTest block and does not affect non-McTest expense flows.

The isProductTrainingElementDismissed utility (src/libs/TooltipUtils.ts) correctly handles both the old string format and the new object format for backward compatibility, so the format change in PR #82255 should not cause the tooltip to be wrongly treated as dismissed.

The root condition that blocks the tooltip for the tester is:

// IOURequestStartPage.tsx line 272
!hasUserSubmittedExpenseOrScannedReceipt && isBetaEnabled(CONST.BETAS.NEWDOT_MANAGER_MCTEST) && selectedTab === CONST.TAB_REQUEST.SCAN && !(isOffline && isWeb)

This means the tooltip only renders for accounts with the NEWDOT_MANAGER_MCTEST beta. @OlGierd03 and @abzokhattab — can you confirm whether the QA tester's account had the NEWDOT_MANAGER_MCTEST beta enabled? If not, this may be a pre-existing design behavior rather than a regression introduced by PR #82255.

Assigned: @OlGierd03 (PR author), @abzokhattab (approving reviewer) from highest-confidence causing PR only
Labels: No label changes made — keeping DeployBlockerCash until root cause is confirmed, as an App PR may need to be reverted or fixed if the beta gate condition is wrong.

📋 Detailed Analysis

Evidence

• The issue was caught during QA execution of PR Resolve @ts-expect-error comments related to OnyxUpdate changes - first batch #82255 ("Resolve @ts-expect-error comments")
• PR Resolve @ts-expect-error comments related to OnyxUpdate changes - first batch #82255 changed the NVP_DISMISSED_PRODUCT_TRAINING value format for SCAN_TEST_TOOLTIP from a plain string to {timestamp, dismissedMethod: 'click'}, but only inside the if (isMoneyRequestToManagerMcTest) guard block in buildOnyxDataForMoneyRequest in src/libs/actions/IOU/index.ts
• The tooltip display condition in IOURequestStartPage.tsx line 272 requires isBetaEnabled(CONST.BETAS.NEWDOT_MANAGER_MCTEST) — a condition PR Resolve @ts-expect-error comments related to OnyxUpdate changes - first batch #82255 did not change
• The issue is staging-only ("N/A - new feature, doesn't exist in prod"), consistent with a beta-gated feature

Verification

• Affected file: src/pages/iou/request/IOURequestStartPage.tsx — the tooltip rendering logic
• Key selector: isTestReceiptTooltipDismissedSelector (line 70) — checks !!nvp?.[SCAN_TEST_TOOLTIP], correctly handles both old string and new object formats
• PR Resolve @ts-expect-error comments related to OnyxUpdate changes - first batch #82255 does NOT modify IOURequestStartPage.tsx — confirmed by checking the PR's file list
• PR Resolve @ts-expect-error comments related to OnyxUpdate changes - first batch #82255 only changes src/libs/actions/IOU/index.ts around the SCAN_TEST_TOOLTIP, inside the McTest-specific guard

Root Cause

The SCAN_TEST_TOOLTIP tooltip in the Create Expense / Scan tab is only rendered when the user's account has the NEWDOT_MANAGER_MCTEST beta flag. The Applause tester account (ibellicotest+2250@gmail.com) does not appear to have this beta enabled. The isProductTrainingElementDismissed helper in src/libs/TooltipUtils.ts handles both old (string) and new (object) dismissal formats correctly, so the format change in PR #82255 is unlikely to be the cause.

If the tester did have the beta enabled and still saw no tooltip, then PR #82255's change to the NVP value format could be indirectly causing an issue via Onyx state hydration — the old format stored a raw string, and any cached/persisted value in the old format might interact differently with the new type expectations. In that case, reverting PR #82255 or patching the selector to handle the new format more robustly would be the fix.

[OlGierd03]

I believe this issue is unrelated to the changes in the PR #82255. The code correctly handles changes related to the value of CONST.PRODUCT_TRAINING_TOOLTIP_NAMES.SCAN_TEST_TOOLTIP for the key ONYXKEYS.NVP_DISMISSED_PRODUCT_TRAINING. I don't know the exact cause of this problem yet. I'll take a closer look at it