Skip to content

Clean up unread indicator method, variable, and component names #8812

Description

@marcaaron

Problem

We have some ambiguous naming conflicts that make the ReportActionsView difficult to understand namely...

  • "marker badge" is hard to distinguish from the "new marker" since they both are "markers"
  • localUnreadActionCount refers to the floating "counter" count and is hard to distinguish from a report's unreadActionCount
  • updateUnreadIndicator refers to the "NEW marker" but could refer to any number of "unread indicators"

Solution

Improve the names so this code is easier to understand.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

EngineeringImprovementItem broken or needs improvement.InternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions