[Due for payment 2026-04-20] Android - Reports - Missing top navigation and filters after rotating device to portrait

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.54-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #85229
Email or phone of affected tester (no customers): jsdjosidjiojisojio3@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Samsung Galaxy S25 FE / Android 16
App Component: Search

Action Performed:

Precondition:

• Have at least an expense in the workspace chat.

1. Launch Expensify app in landscape mode.
2. Go to Reports > Spend over time.
3. Scroll down the chart to the bottom.
4. Rotate the device to portrait.

Expected Result:

Report top navigation and filters will appear after rotating device to portrait.

Actual Result:

Report top navigation and filters do not appear which results in blank area after rotating device to portrait.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7124282_1775609223323.Screen_Recording_20260408_084431_Expensify.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @truph01

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #85229

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

Investigation Summary

Classification: Frontend bug
Causing PR: #85229 - "Unlock landscape mode" by @GCyganek (High confidence)
Related Issues: N/A

Recommendation: REVERT

PR #85229 introduced landscape mode support for phones and is a new feature (not present in production), making it a clean revert candidate. The rotation-triggered layout bug where the top navigation and filters disappear is a direct side effect of the landscape/portrait orientation handling added in this PR.

Assigned: @GCyganek (PR author), @mjasikowski, @rushatgabhane, @truph01 (approving reviewers)
Labels: DeployBlockerCash kept (Frontend bug - fix requires changes in Expensify/App). DeployBlocker not present, no change needed.

Detailed Analysis

Evidence

• The melvin-bot automatically identified PR Unlock landscape mode #85229 as the causing PR (the issue body references it directly).
• PR Unlock landscape mode #85229 is listed in the current StagingDeployCash checklist (version 9.3.54-0) and was merged on 2026-04-07.
• The bug is staging-only ("Reproducible in production?: N/A - new feature, does not exist in prod"), which is consistent with a newly merged staging PR.
• The PR explicitly unlocks landscape orientation on Android and iOS phones and adds new useIsInLandscapeMode hook, isInLandscapeMode utility, and modifies several layout-related components including SafeArea/index.native.tsx, TopBar, HeaderView, and scroll view wrappers.

Verification

• The affected area is the Home page (src/pages/home/HomePage.tsx) displaying the "Spend Over Time" chart within a ScreenWrapper + ScrollView hierarchy.
• PR Unlock landscape mode #85229 modifies the SafeArea component (src/components/SafeArea/index.native.tsx), which now renders different content based on isInLandscapeMode.
• PR Unlock landscape mode #85229 modifies useResponsiveLayout/index.native.ts to add isInLandscapeMode to the returned result, which is consumed by TopBar and other navigation components.
• The TopBar component (src/components/Navigation/TopBar.tsx) was modified in this PR to add onTouchStart behavior based on isInLandscapeMode. The TopBar is used directly in HomePage.
• The PR also modified BaseModal.tsx to introduce shouldWrapModalChildrenInScrollViewIfBottomDockedInLandscapeMode, changing modal scroll behavior.

Root Cause

When a device rotates from landscape to portrait after scrolling down in the "Spend Over Time" chart, the layout components added by PR #85229 do not properly recompute their positions. Specifically, the isInLandscapeMode state changes from true to false on rotation, but the ScrollView scroll offset or the SafeArea insets may not be fully recalculated, leaving the TopBar and filter components hidden or positioned off-screen. This is a layout regression introduced by the new orientation-detection logic in this PR.