[Due for payment 2026-05-11] [$250] Task complete sound is heard when disabling category

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.3.51-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #81814
Email or phone of affected tester (no customers): testpayment935@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Windows
App Component: Workspace Settings

Action Performed:

1. Navigate to staging.new.expensify.com
2. Create a new Gmail account.
3. Click Skip on work email step.
4. Select Something else and complete onboarding.
5. Create a workspace.
6. Delete the workspace.
7. Create another workspace.
8. Go to Categories.
9. Edit the category by disabling a category.

Expected Result:

No task complete sound in the background.

Actual Result:

There is background tax complete sound.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Video.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @mallenexpensify

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022039314347090291822
• Upwork Job ID: 2039314347090291822
• Last Price Increase: 2026-04-01

[MelvinBot]

Proposal

What is the root cause of that problem?

When a user toggles a category (enable or disable), setWorkspaceCategoryEnabled (Category.ts:368-478) unconditionally calls appendSetupCategoriesOnboardingData at line 450. This chains through getFinishOnboardingTaskOnyxData (Task.ts:1404-1421) → completeTask (Task.ts:479-503), which calls playSound(SOUNDS.SUCCESS) at line 500. This plays success.mp3 — the "task complete" sound.

The sound plays because:

1. The onboarding task (setupCategories) is stored globally in NVP_INTRO_SELECTED — it is not scoped to any specific workspace/policy.
2. useOnboardingTaskInformation (useOnboardingTaskInformation.ts:8-23) reads from this global NVP with no workspace filtering, and the result is passed into every setWorkspaceCategoryEnabled call from WorkspaceCategoriesPage (WorkspaceCategoriesPage.tsx:101-212) and CategorySettingsPage (CategorySettingsPage.tsx:180-221).
3. When the original workspace is deleted and a new one created, the old onboarding task remains in an incomplete state, so the first category toggle on the new workspace completes it and plays the sound.

The sound only plays once (on the first toggle after onboarding), because after completeTask runs, the task's stateNum becomes APPROVED and the guard at Task.ts:1414 prevents it from firing again.

What changes do you think we should make in order to solve the problem?

The appendSetupCategoriesOnboardingData call in setWorkspaceCategoryEnabled should be skipped when categories are being disabled. Conceptually, disabling a category is not "setting up categories" — only enabling a category should count as completing the onboarding task.

In setWorkspaceCategoryEnabled (Category.ts), wrap the two appendSetupCategoriesOnboardingData calls (lines ~450 and ~460) in a condition that checks whether at least one category in categoriesToUpdate is being enabled (i.e., enabled: true). If all categories are being disabled, skip the onboarding task completion entirely.

The same fix should apply to the SETUP_CATEGORIES_AND_TAGS block (~line 460) that follows the same pattern.

What alternative solutions did you explore? (Optional)

1. Scope the onboarding task to the workspace — Make NVP_INTRO_SELECTED policy-aware so the task only completes on the workspace where onboarding occurred. This is a larger change affecting multiple flows and is over-scoped for this fix.
2. Clean up onboarding tasks on workspace deletion — Mark the task as APPROVED when the associated workspace is deleted. This would prevent the sound but would require coordinating between workspace deletion and onboarding task lifecycle, which is also a bigger change.
3. Suppress the sound in getFinishOnboardingTaskOnyxData — Refactor completeTask to accept a silent flag. This would work but doesn't address the conceptual issue that disabling a category shouldn't complete an onboarding task at all.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

[samranahm]

🚨 Edited by proposal-police: This proposal was edited at 2026-04-01 12:12:30 UTC.

Proposal

Task complete sound is heard when disabling category

What is the root cause of that problem?

Disabling a category is incorrectly treated like finishing the onboarding “set up categories” task.
That task-complete flow triggers the success sound, so users hear the task complete audio even though they only disabled a catego

What changes do you think we should make in order to solve the problem?

We should only run onboarding task completion when the action is progress-forward (for example creating or enabling categories), not when disabling categories.

const isEnablingAnyCategory = Object.values(categoriesToUpdate).some((category) => category.enabled);

if (isEnablingAnyCategory) {
    appendSetupCategoriesOnboardingData(
        onyxData,
        setupCategoryTaskReport,
        setupCategoryTaskParentReport,
        isSetupCategoriesTaskParentReportArchived,
        currentUserAccountID,
        hasOutstandingChildTask,
        parentReportAction,
    );

    if (setupCategoriesAndTagsTaskReport && policyHasTags) {
        appendSetupCategoriesOnboardingData(
            onyxData,
            setupCategoriesAndTagsTaskReport,
            setupCategoriesAndTagsTaskParentReport,
            isSetupCategoriesAndTagsTaskParentReportArchived ?? false,
            currentUserAccountID,
            setupCategoriesAndTagsHasOutstandingChildTask ?? false,
            setupCategoriesAndTagsParentReportAction,
        );
    }

here

App/src/libs/actions/Policy/Category.ts

Lines 450 to 470 in 598b3e3

	appendSetupCategoriesOnboardingData(
	onyxData,
	setupCategoryTaskReport,
	setupCategoryTaskParentReport,
	isSetupCategoriesTaskParentReportArchived,
	currentUserAccountID,
	hasOutstandingChildTask,
	parentReportAction,
	);
	if (setupCategoriesAndTagsTaskReport && policyHasTags) {
	appendSetupCategoriesOnboardingData(
	onyxData,
	setupCategoriesAndTagsTaskReport,
	setupCategoriesAndTagsTaskParentReport,
	isSetupCategoriesAndTagsTaskParentReportArchived ?? false,
	currentUserAccountID,
	setupCategoriesAndTagsHasOutstandingChildTask ?? false,
	setupCategoriesAndTagsParentReportAction,
	);
	}

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Eskalifer1 (External)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022039314347090291822

[KJ21-ENG]

🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.

[github-actions]

⚠️ @KJ21-ENG Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Task complete sound is heard when disabling category

What is the root cause of that problem?

We are completing the onboarding tasks without checking if isTaskForCurrentWorkspace

App/src/libs/actions/Policy/Category.ts

Lines 450 to 470 in 63d65b4

	appendSetupCategoriesOnboardingData(
	onyxData,
	setupCategoryTaskReport,
	setupCategoryTaskParentReport,
	isSetupCategoriesTaskParentReportArchived,
	currentUserAccountID,
	hasOutstandingChildTask,
	parentReportAction,
	);
	if (setupCategoriesAndTagsTaskReport && policyHasTags) {
	appendSetupCategoriesOnboardingData(
	onyxData,
	setupCategoriesAndTagsTaskReport,
	setupCategoriesAndTagsTaskParentReport,
	isSetupCategoriesAndTagsTaskParentReportArchived ?? false,
	currentUserAccountID,
	setupCategoriesAndTagsHasOutstandingChildTask ?? false,
	setupCategoriesAndTagsParentReportAction,
	);
	}

so it completes the task in the deleted workspace even if it is archived.

What changes do you think we should make in order to solve the problem?

Just like we are doing for tags here

App/src/libs/actions/Policy/Tag.ts

Lines 219 to 220 in 63d65b4

	if (setupTagsTaskReport && currentUserAccountID && isTaskForCurrentWorkspace(setupTagsTaskReport)) {
	getFinishOnboardingTaskOnyxData(

( we should re-do what is implemented in #81814 for tags )
we need to first check isTaskForCurrentWorkspace and only complete it if it is true. We should implement this check either in appendSetupCategoriesOnboardingData(by passing policyID as a param) or in places it is used.
We just need to compare the setupCategoryTaskReport/setupCategoriesAndTagsTaskReport's policy with the policy whose category is update similar to isTaskForCurrentWorkspace here

App/src/libs/actions/Policy/Tag.ts

Line 216 in 63d65b4

const isTaskForCurrentWorkspace = (taskReport: OnyxEntry<Report>) => !taskReport?.policyID || taskReport.policyID === policyID;

What alternative solutions did you explore? (Optional)

[github-actions]

⚠️ @FitseTLT Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.