Skip to content

[Due for payment 2026-03-24] [$250] Workspace address: send discrete SetPolicyAddress params and keep legacy display compatibility #84378

Closed
Closed
[Due for payment 2026-03-24] [$250] Workspace address: send discrete SetPolicyAddress params and keep legacy display compatibility#84378
Assignees
mallenexpensifyc3024eh2077
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ReviewingHas a PR in review

Description

@c3024
c3024
opened on Mar 6, 2026

Problem

App still sends legacy nested params (data[addressStreet], etc.) for SetPolicyAddress, and still concatenates line 1 + line 2 into addressStreet with \n.

Parent issue: https://github.com/Expensify/Expensify/issues/394853

Solution

  • Update SetPolicyAddress params to flat fields in:
    • src/libs/API/parameters/UpdatePolicyAddressParams.ts
    • src/libs/actions/Policy/Policy.ts
  • Add addressStreet2?: string to CompanyAddress in:
    • src/types/onyx/Policy.ts
  • Stop newline concatenation when submitting workspace address in:
    • src/pages/workspace/WorkspaceOverviewAddressPage.tsx
    • src/pages/Travel/WorkspaceAddressForTravelPage.tsx
  • Update display/read compatibility to support both:
    • New format: addressStreet + addressStreet2
    • Legacy format: addressStreet containing \n
  • Compatibility updates in:
    • src/pages/workspace/WorkspaceOverviewPage.tsx
    • src/pages/workspace/duplicate/WorkspaceDuplicateSelectFeaturesForm.tsx
    • src/libs/ReportActionsUtils.ts
    • src/pages/workspace/WorkspaceOverviewAddressPage.tsx (form prefill path)
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. c3024
    self-assigned this
    on Mar 6, 2026
  2. c3024
    added
    DailyKSv2
    on Mar 6, 2026

  3. c3024 commented on Mar 6, 2026

    @c3024
    c3024
    on Mar 6, 2026
    ContributorAuthor

    This is not open for proposals. I am working on this.

  4. melvin-bot
    added
    ReviewingHas a PR in review
    WeeklyKSv2
    and removed
    DailyKSv2
    WeeklyKSv2
    on Mar 6, 2026

  5. eh2077 commented on Mar 18, 2026

    @eh2077
    eh2077
    on Mar 18, 2026
    Contributor

    @c3024 can I get assigned to track payment for reviewing the PR? thx 🙇

  6. c3024
    assigned
    eh2077
    on Mar 18, 2026
  7. c3024
    added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on Mar 18, 2026
  8. melvin-bot
    assigned
    mallenexpensify
    on Mar 18, 2026

  9. melvin-bot commented on Mar 18, 2026

    @melvin-bot
    melvin-botbot
    on Mar 18, 2026 – with Melvin Bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  10. c3024
    changed the title [-]Workspace address: send discrete SetPolicyAddress params and keep legacy display compatibility[/-] [+][Due for payment 2026-03-24] [$250] Workspace address: send discrete SetPolicyAddress params and keep legacy display compatibility[/+] on Mar 18, 2026

  11. melvin-bot commented on Mar 18, 2026

    @melvin-bot
    melvin-botbot
    on Mar 18, 2026 – with Melvin Bot

    ⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

  12. c3024 commented on Mar 18, 2026

    @c3024
    c3024
    on Mar 18, 2026
    ContributorAuthor

    @mallenexpensify

    @eh2077 reviewed the PR. I think the standard payout for him is applicable here. Thanks!

  13. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Mar 24, 2026

  14. melvin-bot commented on Mar 24, 2026

    @melvin-bot
    melvin-botbot
    on Mar 24, 2026 – with Melvin Bot

    Payment Summary

    Upwork Job

    • Contributor: @c3024 does not require payment (Contractor)
    • Reviewer: @eh2077 owed $250 via NewDot

    BugZero Checklist (@mallenexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct

  15. mallenexpensify commented on Mar 24, 2026

    @mallenexpensify
    mallenexpensify
    on Mar 24, 2026
    Contributor

    Payment Summary

    Contributor+: @eh2077 due $250 via NewDot

    Thx

  16. mallenexpensify
    closed this as completedon Mar 24, 2026

  17. laurenreidexpensify commented on Apr 27, 2026

    @laurenreidexpensify
    laurenreidexpensify
    on Apr 27, 2026
    Contributor

    $250 approved for @eh2077

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions