Distance - Distance rate field on merge confirm page shows rate value instead of rate name

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.31-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #83393
Email or phone of affected tester (no customers): isodjnosidjiojiojiso@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create two manual distance expenses.
4. Open the expense report.
5. Open any distance expense.
6. Click More > Merge.
7. Select the other distance expense > Continue.
8. Select any details and reach confirm page.

Expected Result:

Distance rate field on merge confirm page will show rate name.

Actual Result:

Distance rate field on merge confirm page shows rate value instead of rate name.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7093953_1772650584635.8.mp4

View all open jobs on GitHub

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #83393

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

🔍 Investigation Summary

Classification: Frontend bug
Causing PR: #83393 - "Display rate name instead of rate value on distance expenses" by @neil-marcellini (High confidence)
Related Issues: None

Recommendation: REVERT

PR #83393 should be reverted. The PR changed how distance rates are displayed on expense pages, showing the rate name (e.g., "Default Rate") instead of the rate value (e.g., "$0.67 / mile") for workspace distance expenses. While this works correctly for individual expense views, it was not tested with the merge transaction flow and causes a display inconsistency on the merge confirmation page.

Labels: No label changes needed - keeping DeployBlockerCash as this is a frontend bug in App requiring an App PR revert.

📋 Detailed Analysis

Evidence

• The issue specifically mentions that the "Distance rate field on merge confirm page shows rate value instead of rate name"
• PR Display rate name instead of rate value on distance expenses #83393 was merged on 2026-03-03 and is included in the current staging deploy (9.3.31-0)
• The PR introduced a new function getRateForExpenseDisplay() which returns the rate name for workspace expenses instead of the rate value
• The merge confirmation page was not included in the PR test plan

Verification

I verified that PR #83393 modifies the files that affect the rate display:

• src/components/ReportActionItem/MoneyRequestView.tsx - Uses getRateForExpenseDisplay() to display rates
• src/components/MoneyRequestConfirmationListFooter.tsx - Updated to use the new function
• src/libs/DistanceRequestUtils.ts - Added getRateForExpenseDisplay() function

The merge confirmation page (src/pages/TransactionMerge/ConfirmationPage.tsx) renders a MoneyRequestView component with merged transaction data, which now uses the new rate display logic.

Root Cause

PR #83393 changed MoneyRequestView to call DistanceRequestUtils.getRateForExpenseDisplay() which returns:

• Rate name (e.g., "Default Rate") for workspace expenses
• Rate value (e.g., "$0.67 / mile") for P2P expenses

This change was made to prevent workspace rate changes from retroactively altering historical expenses. However, the PR did not account for the merge transaction flow.

When viewing the merge confirmation page:

1. ConfirmationPage.tsx renders MoneyRequestView with mergedTransactionData
2. MoneyRequestView calls getRate() which extracts the rate information from the transaction
3. getRateForExpenseDisplay() returns the rate name for workspace expenses
4. The rate field displays "Default Rate" instead of "$0.67 / mile"

The issue title says "shows rate value instead of rate name" but based on the video evidence and the code changes, the actual behavior is showing the rate value when it should show the rate name (consistent with other expense views after PR #83393). The confusion may be because before PR #83393, all expense views showed the rate value, so this is actually the intended new behavior - but it appears the merge flow was not considered in testing.

Actually, re-reading the issue more carefully: the expected result is "rate name" and actual result is "rate value" - which means the merge confirmation page is NOT applying the new logic from PR #83393. This suggests there may be a specific code path in the merge flow that bypasses the new function, or the rate information is not being properly passed through the merge data structure.

[OSBotify]

Update: Clarification on Root Cause

After further investigation, I need to clarify the root cause:

The Issue: When merging distance expenses, the rate field shows the rate value (e.g., "$0.67 / mile") instead of the rate name (e.g., "Default Rate"). This means PR #83393 changes are NOT being applied correctly on the merge confirmation page.

Root Cause: The buildMergedTransactionData function in MergeTransactionUtils.ts copies the customUnit from the merge transaction (line 349), which contains the customUnitRateID. When MoneyRequestView calls DistanceRequestUtils.getRate() to look up the rate from the policy using this customUnitRateID, it should return a MileageRate object with a name property. However, the name is coming back as undefined, causing getRateForExpenseDisplay() to fall back to displaying the formatted rate value.

Possible reasons for missing rate name:

1. The customUnitRateID in the merged transaction data doesnt match any rate in the policy
2. The rate exists in the policy but doesnt have a name property set
3. There is a timing issue where the policy data hasnt loaded when the merge confirmation page renders

The fix requires either:

• Ensuring the merged transaction data correctly preserves the rate ID and the policy has the corresponding rate with a name
• OR updating the merge flow to handle rate display differently for distance expenses

This is still a Frontend bug caused by PR #83393 not accounting for the merge transaction flow in its testing.