[Due for payment 2026-03-13] Expense - Tapping rate field is not responsive in distance expense confirm page

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.3.30-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #74967
Email or phone of affected tester (no customers): dreamnitethedragon@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Redminote 10S Android 13
App Component: Money Requests

Action Performed:

1. Launch app
2. Login with new account
3. Tap fab - track distance
4. Select 2 waypoints and tap next
5. Select self DM
6. Tap rate

Expected Result:

Tapping rate field must be responsive in distance expense confirm page.

Actual Result:

Tapping rate field is not responsive in distance expense confirm page.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #74967

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

🔍 Investigation Summary

Classification: Frontend bug
Causing PR: #84084 - "[CP Staging] Revert Merge pull request #74967" by @FitseTLT (High confidence)
Related Issues: This is a regression from the partial revert of PR #74967

Recommendation: ROLL FORWARD

A fix PR is needed to make the interactive prop consistent with the shouldShowRightIcon prop. PR #84084 incompletely reverted PR #74967, causing a mismatch between these two props.

Labels: No label changes needed - this is clearly a frontend bug that blocks the App deploy, so DeployBlockerCash should remain.

📋 Detailed Analysis

Evidence

Issue #84137 reports that tapping the rate field is not responsive on the distance expense confirm page when tracking distance in selfDM (unreported expense).

PR #74967 originally made changes to enable the rate field for track/unreported expenses by removing !isUnreported from both:

• shouldShowRightIcon prop (controls whether the chevron icon shows)
• interactive prop (controls whether the field is clickable)

However, PR #74967 caused multiple deploy blockers (issues #83953, #83955, #83957, #83958, #83964, #83972, #83990, #84006, #84007, #84010, #84013), so it was partially reverted via PR #84084.

Verification

Examining the staging branch file content confirms:

• Line 588: shouldShowRightIcon={!!rate && !isReadOnly && iouType !== CONST.IOU.TYPE.SPLIT} (no !isUnreported)
• Line 628: interactive={!!rate && !isReadOnly && iouType !== CONST.IOU.TYPE.SPLIT && !isUnreported} (HAS !isUnreported)

PR #84084 diff shows it reverted the interactive prop change but not the shouldShowRightIcon change:

-interactive={!!rate && !isReadOnly && iouType !== CONST.IOU.TYPE.SPLIT}
+interactive={!!rate && !isReadOnly && iouType !== CONST.IOU.TYPE.SPLIT && !isUnreported}

This mismatch causes the chevron icon to appear (suggesting the field is clickable) but the field does not respond to taps.

Root Cause

The partial revert in PR #84084 created an inconsistency between the visual indicator (shouldShowRightIcon) and the actual interactivity (interactive) of the rate field. For unreported/track distance expenses in selfDM (isUnreported === true):

• The chevron icon is shown (because shouldShowRightIcon has no !isUnreported check)
• But taps do nothing (because interactive includes !isUnreported, making it false)

Fix

The fix should either:

1. Re-add !isUnreported to shouldShowRightIcon to match interactive (making the field non-interactive for unreported expenses)
2. Remove !isUnreported from interactive to match shouldShowRightIcon (making the field interactive for unreported expenses)

Option 1 is recommended since PR #74967 was reverted due to multiple issues with enabling this functionality for unreported expenses.

[MelvinBot]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tapping the rate field on the distance expense confirmation page does nothing when creating a distance expense in self DM. The field appears non-interactive (no right arrow icon, no response to taps).

What is the root cause of that problem?

The interactive prop on the rate field's MenuItemWithTopDescription includes the condition !isUnreported, which evaluates to false for self DM distance expenses — making the field non-tappable.

In MoneyRequestConfirmationListFooter.tsx:625:

interactive={!!rate && !isReadOnly && iouType !== CONST.IOU.TYPE.SPLIT && !isUnreported}

When a user selects self DM as the participant, IOURequestStepParticipants.tsx:198 sets the transaction's reportID to CONST.REPORT.UNREPORTED_REPORT_ID ('0'). Then in the footer at line 338:

const isUnreported = transaction?.reportID === CONST.REPORT.UNREPORTED_REPORT_ID;

This evaluates to true, making !isUnreported → false, which forces interactive to false. The same condition on line 595 also hides the right arrow icon.

Note: the rate value itself is valid (~72.5 for USD, sourced from CURRENCY_TO_DEFAULT_MILEAGE_RATE via getRateForP2P), so !!rate passes. The issue is specifically !isUnreported.

PR #74967 previously fixed this by removing !isUnreported, but it was reverted via PR #84084 ([CP Staging] Revert), reintroducing this behavior.

What changes do you think we should make in order to solve the problem?

In src/components/MoneyRequestConfirmationListFooter.tsx, remove && !isUnreported from both conditions on the rate field:

Line 595 — change shouldShowRightIcon:

shouldShowRightIcon={!!rate && !isReadOnly && iouType !== CONST.IOU.TYPE.SPLIT}

Line 625 — change interactive:

interactive={!!rate && !isReadOnly && iouType !== CONST.IOU.TYPE.SPLIT}

The existing onPress handler (lines 607-619) already correctly handles the self DM case: when !isPolicyExpenseChat, it navigates to MONEY_REQUEST_UPGRADE with the DISTANCE_RATES upgrade path. Removing the !isUnreported guard allows users to tap the field and reach this upgrade flow.

What alternative solutions did you explore? (Optional)

An alternative would be to re-land all changes from the reverted PR #74967 (which also modified the onPress routing logic for track expenses). However, since that PR was reverted in its entirety, the minimal fix of just removing !isUnreported is safer and directly addresses this specific bug while keeping the existing onPress behavior intact.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.