Skip to content

[BT-142] Migrate Workspace - Expensify Cards (Part 2) #83864

Description

@mjasikowski

Description

Current State:

  • 5 routes for Expensify card configuration and issuance
  • These routes use backTo parameter for return navigation

Implementation:

  • Replace getRoute(..., backTo) with createDynamicRoute()
  • Add source screens to entryScreens array
  • Remove backTo parameter from route definitions
  • Test forward/back navigation

Scope

Routes (5):

Route Constant Path
WORKSPACE_EXPENSIFY_CARD_LIMIT_TYPE workspaces/:policyID/expensify-card/:cardID/edit/limit-type
WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW workspaces/:policyID/expensify-card/issue-new
WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW_CONFIRM_MAGIC_CODE workspaces/:policyID/expensify-card/issue-new/confirm-magic-code
WORKSPACE_EXPENSIFY_CARD_SETTINGS_ACCOUNT workspaces/:policyID/expensify-card/settings/account
WORKSPACE_EXPENSIFY_CARD_SELECT_FEED workspaces/:policyID/expensify-card/select-feed

Usages

WORKSPACE_EXPENSIFY_CARD_LIMIT_TYPE:

  • Search for usages in card limit type flow

WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW:

  • Search for usages in card issue new flow

WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW_CONFIRM_MAGIC_CODE:

  • src/pages/workspace/expensifyCard/issueNew/IssueNewCardConfirmMagicCodePage.tsx

WORKSPACE_EXPENSIFY_CARD_SETTINGS_ACCOUNT:

  • src/pages/workspace/expensifyCard/WorkspaceSettlementAccountPage.tsx:164

WORKSPACE_EXPENSIFY_CARD_SELECT_FEED:

  • Search for usages in card feed selection flow

Files to modify:

  • src/ROUTES.ts - Update route definitions
  • src/libs/Navigation/types.ts - Remove backTo from params
  • Components listed above

Migration Progress

  • WORKSPACE_EXPENSIFY_CARD_LIMIT_TYPE
  • WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW
  • WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW_CONFIRM_MAGIC_CODE
  • WORKSPACE_EXPENSIFY_CARD_SETTINGS_ACCOUNT
  • WORKSPACE_EXPENSIFY_CARD_SELECT_FEED
Issue OwnerCurrent Issue Owner: @mananjadhav

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

InternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions