Skip to content

[BT-114] Migrate Workspace - Xero #83842

Description

@mjasikowski

Description

Current State:

  • 5 routes for Xero export and advanced configuration
  • These routes use backTo parameter for return navigation

Implementation:

  • Replace getRoute(..., backTo) with createDynamicRoute()
  • Add source screens to entryScreens array
  • Remove backTo parameter from route definitions
  • Test forward/back navigation

Scope

Routes (5):

Route Constant Path
POLICY_ACCOUNTING_XERO_EXPORT_BANK_ACCOUNT_SELECT workspaces/:policyID/accounting/xero/export/bank-account-select
POLICY_ACCOUNTING_XERO_BILL_STATUS_SELECTOR workspaces/:policyID/accounting/xero/export/purchase-bill-status-selector
WORKSPACE_ACCOUNTING_XERO_AUTO_SYNC workspaces/:policyID/accounting/xero/advanced/autosync
WORKSPACE_ACCOUNTING_XERO_ACCOUNTING_METHOD workspaces/:policyID/accounting/xero/advanced/autosync/accounting-method
WORKSPACE_ACCOUNTING_CARD_RECONCILIATION_ACCOUNT workspaces/:policyID/accounting/:connection/card-reconciliation/account

Usages

POLICY_ACCOUNTING_XERO_EXPORT_BANK_ACCOUNT_SELECT:

  • Search for usages in Xero bank account select flow

POLICY_ACCOUNTING_XERO_BILL_STATUS_SELECTOR:

  • Search for usages in Xero bill status flow

WORKSPACE_ACCOUNTING_XERO_AUTO_SYNC:

  • Search for usages in Xero auto sync flow

WORKSPACE_ACCOUNTING_XERO_ACCOUNTING_METHOD:

  • Search for usages in Xero accounting method flow

WORKSPACE_ACCOUNTING_CARD_RECONCILIATION_ACCOUNT:

  • src/pages/workspace/accounting/reconciliation/ReconciliationAccountSettingsPage.tsx

Files to modify:

  • src/ROUTES.ts - Update route definitions
  • src/libs/Navigation/types.ts - Remove backTo from params
  • Components listed above

Migration Progress

  • POLICY_ACCOUNTING_XERO_EXPORT_BANK_ACCOUNT_SELECT
  • POLICY_ACCOUNTING_XERO_BILL_STATUS_SELECTOR
  • WORKSPACE_ACCOUNTING_XERO_AUTO_SYNC
  • WORKSPACE_ACCOUNTING_XERO_ACCOUNTING_METHOD
  • WORKSPACE_ACCOUNTING_CARD_RECONCILIATION_ACCOUNT
Issue OwnerCurrent Issue Owner: @mananjadhav

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions