Skip to content

[BT-111] Migrate Workspace - QBO Advanced + QBD #83839

Description

@mjasikowski

Description

Current State:

  • 5 routes for QBO advanced settings and QuickBooks Desktop export
  • These routes use backTo parameter for return navigation

Implementation:

  • Replace getRoute(..., backTo) with createDynamicRoute()
  • Add source screens to entryScreens array
  • Remove backTo parameter from route definitions
  • Test forward/back navigation

Scope

Routes (5):

Route Constant Path
WORKSPACE_ACCOUNTING_QUICKBOOKS_ONLINE_AUTO_SYNC workspaces/:policyID/connections/quickbooks-online/advanced/autosync
WORKSPACE_ACCOUNTING_QUICKBOOKS_ONLINE_ACCOUNTING_METHOD workspaces/:policyID/connections/quickbooks-online/advanced/autosync/accounting-method
POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_EXPORT workspaces/:policyID/accounting/quickbooks-desktop/export
POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_COMPANY_CARD_EXPENSE_ACCOUNT workspaces/:policyID/accounting/quickbooks-desktop/export/company-card-expense-account
POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_COMPANY_CARD_EXPENSE_ACCOUNT_SELECT workspaces/:policyID/accounting/quickbooks-desktop/export/company-card-expense-account/account-select

Usages

WORKSPACE_ACCOUNTING_QUICKBOOKS_ONLINE_AUTO_SYNC:

  • Search for usages in QBO auto sync flow

WORKSPACE_ACCOUNTING_QUICKBOOKS_ONLINE_ACCOUNTING_METHOD:

  • Search for usages in QBO accounting method flow

POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_EXPORT:

  • src/pages/workspace/accounting/qbd/export/QuickbooksDesktopPreferredExporterConfigurationPage.tsx:40
  • src/pages/workspace/accounting/qbd/export/QuickbooksDesktopExportDateSelectPage.tsx:48
  • src/pages/workspace/accounting/utils.tsx:285

POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_COMPANY_CARD_EXPENSE_ACCOUNT:

  • src/pages/workspace/accounting/qbd/export/QuickbooksDesktopCompanyCardExpenseAccountPage.tsx

POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_COMPANY_CARD_EXPENSE_ACCOUNT_SELECT:

  • Search for usages in QBD account select flow

Files to modify:

  • src/ROUTES.ts - Update route definitions
  • src/libs/Navigation/types.ts - Remove backTo from params
  • Components listed above

Migration Progress

  • WORKSPACE_ACCOUNTING_QUICKBOOKS_ONLINE_AUTO_SYNC
  • WORKSPACE_ACCOUNTING_QUICKBOOKS_ONLINE_ACCOUNTING_METHOD
  • POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_EXPORT
  • POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_COMPANY_CARD_EXPENSE_ACCOUNT
  • POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_COMPANY_CARD_EXPENSE_ACCOUNT_SELECT
Issue OwnerCurrent Issue Owner: @mananjadhav

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions