Skip to content

[BT-108] Migrate Workspace - Expensify Cards Settings #83836

Description

@mjasikowski

Description

Current State:

  • 4 routes for Expensify card settings panel
  • These routes use backTo parameter for return navigation

Implementation:

  • Replace getRoute(..., backTo) with createDynamicRoute()
  • Add source screens to entryScreens array
  • Remove backTo parameter from route definitions
  • Test forward/back navigation

Scope

Routes (4):

Route Constant Path
EXPENSIFY_CARD_DETAILS settings/:policyID/expensify-card/:cardID
EXPENSIFY_CARD_NAME settings/:policyID/expensify-card/:cardID/edit/name
EXPENSIFY_CARD_LIMIT settings/:policyID/expensify-card/:cardID/edit/limit
EXPENSIFY_CARD_LIMIT_TYPE settings/:policyID/expensify-card/:cardID/edit/limit-type

Usages

EXPENSIFY_CARD_DETAILS:

  • Search for usages in settings expensify card details flow

EXPENSIFY_CARD_NAME:

  • Search for usages in card name edit flow

EXPENSIFY_CARD_LIMIT:

  • Search for usages in card limit edit flow

EXPENSIFY_CARD_LIMIT_TYPE:

  • Search for usages in card limit type flow

Files to modify:

  • src/ROUTES.ts - Update route definitions
  • src/libs/Navigation/types.ts - Remove backTo from params
  • Components listed above

Migration Progress

  • EXPENSIFY_CARD_DETAILS
  • EXPENSIFY_CARD_NAME
  • EXPENSIFY_CARD_LIMIT
  • EXPENSIFY_CARD_LIMIT_TYPE
Issue OwnerCurrent Issue Owner: @mananjadhav

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

InternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions