Skip to content

[BT-105] Migrate Workspace - Tags (Part 2) #83833

Description

@mjasikowski

Description

Current State:

  • 5 routes for workspace tag editing and configuration
  • These routes use backTo parameter for return navigation

Implementation:

  • Replace getRoute(..., backTo) with createDynamicRoute()
  • Add source screens to entryScreens array
  • Remove backTo parameter from route definitions
  • Test forward/back navigation

Scope

Routes (5):

Route Constant Path
WORKSPACE_EDIT_TAGS workspaces/:policyID/tags/:orderWeight/edit
WORKSPACE_TAG_SETTINGS workspaces/:policyID/tag/:orderWeight/:tagName
WORKSPACE_TAG_EDIT workspaces/:policyID/tag/:orderWeight/:tagName/edit
WORKSPACE_TAG_GL_CODE workspaces/:policyID/tag/:orderWeight/:tagName/gl-code
WORKSPACE_TAG_APPROVER workspaces/:policyID/tag/:orderWeight/:tagName/approver

Usages

WORKSPACE_EDIT_TAGS:

  • Search for usages in tag list editing flow

WORKSPACE_TAG_SETTINGS:

  • src/pages/workspace/tags/TagGLCodePage.tsx:46
  • src/pages/workspace/tags/WorkspaceViewTagsPage.tsx:212

WORKSPACE_TAG_EDIT:

  • Search for usages in tag editing flow

WORKSPACE_TAG_GL_CODE:

  • Search for usages in tag GL code flow

WORKSPACE_TAG_APPROVER:

  • Search for usages in tag approver flow

Files to modify:

  • src/ROUTES.ts - Update route definitions
  • src/libs/Navigation/types.ts - Remove backTo from params
  • Components listed above

Migration Progress

  • WORKSPACE_EDIT_TAGS
  • WORKSPACE_TAG_SETTINGS
  • WORKSPACE_TAG_EDIT
  • WORKSPACE_TAG_GL_CODE
  • WORKSPACE_TAG_APPROVER
Issue OwnerCurrent Issue Owner: @suneox

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2InternalRequires API changes or must be handled by Expensify staffSkip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions