Search - Change log after tax tracking is enabled is shown on LHN but not on "Search"

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.25-13
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #79161
Email or phone of affected tester (no customers): ibellicotest+2250@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Motorola MotoG60 / Android 12 (Hybrid app) - Windows 11 / Chrome
App Component: Search

Action Performed:

1. Open the Expensify app.
2. Sign up with a new account.
3. Create a new workspace.
4. Make any change to it that generates a change log. (For example: Enable approvals and payments)
5. Navigate to "Inbox"
6. Note that a thread was created with the changes made and that last message is visible on chat preview.
7. Tap on the search icon on the top right corner.
8. Note that last message from thread is also visible on chat preview.
9. Navigate to "Workspace" > "More Features" and enable taxes.
10. Return to "Inbox"
11. Note that "Enabled Tax Tracking" is visible on thread chat preview and also inside chat.
12. Tap on the search icon again.
13. Note that chat preview only shows the word "Thread"
14. Return to "Workspaces" > "More Features" and disable "Taxes"
15. Note that change log generated this time, is also visible on threaded chat preview on "Inbox" and inside chat, but is not visible on preview on "Search"

Expected Result:

Change logs that are generated when "taxes" are enabled or disabled, should be visible on chat preview on "Inbox" and also on preview on "Search"

Actual Result:

Change logs generated after "taxes" are enabled or disabled, are visible on threaded chat and on chat preview on "Inbox", but are not displayed on preview on "Search", where only the word "Thread" is displayed.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

[ryntgh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search - Change log after tax tracking is enabled is shown on LHN but not on "Search"

What is the root cause of that problem?

Change logs for enabling/disabling tax tracking use the POLICY_CHANGE_LOG.UPDATE_FEATURE_ENABLED action. In getLastMessageTextForReport in OptionsListUtils, there is no handler for this action, so the last message text is empty. For threads with no formattedLastMessageText, getAlternateText falls back to the "Thread" label.

App/src/libs/OptionsListUtils/index.ts

Lines 473 to 476 in 04446e8

	if (option.isThread) {
	// eslint-disable-next-line @typescript-eslint/no-deprecated
	return showChatPreviewLine && formattedLastMessageText ? formattedLastMessageTextWithPrefix : translateLocal('threads.thread');
	}

SidebarUtils correctly handles this action for the LHN.

App/src/libs/SidebarUtils.ts

Lines 974 to 975 in 04446e8

	} else if (lastAction?.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_FEATURE_ENABLED) {
	result.alternateText = getWorkspaceFeatureEnabledMessage(translate, lastAction);

What changes do you think we should make in order to solve the problem?

Add handling for UPDATE_FEATURE_ENABLED in getLastMessageTextForReport so Search shows the same change log text as the LHN

    if (isActionOfType(lastReportAction, CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_FEATURE_ENABLED)) {
        lastMessageTextFromReport = getWorkspaceFeatureEnabledMessage(translate, lastReportAction);
    }

App/src/libs/OptionsListUtils/index.ts

Lines 818 to 822 in 04446e8

	}
	if (isActionOfType(lastReportAction, CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_AUTO_PAY_APPROVED_REPORTS_ENABLED)) {
	lastMessageTextFromReport = getAutoPayApprovedReportsEnabledMessage(translate, lastReportAction);
	}
	if (isActionOfType(lastReportAction, CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_AUTO_REIMBURSEMENT)) {

We could check for another action or handle all POLICY_CHANGE_LOG actions that already handled in SidebarUtils for consistency

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

@jponikarchuk, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.