Skip to content

Add reasonAttributes to MergeExpensesSkeleton usage sites #83405

Closed

Description

@MelvinBot

Problem

As part of #81683, we need to add reasonAttributes to all skeleton components so that Sentry spans carry structured metadata about why a loading indicator is visible. This helps engineers debug infinite skeleton loading states.

Solution

Add reasonAttributes to all usage sites of MergeExpensesSkeleton (src/components/Skeletons/MergeExpensesSkeleton.tsx).

At each usage site:

  1. Pass a reasonAttributes prop with a context string identifying the parent component (e.g. 'ParentComponent.ChildComponent')
  2. Include relevant boolean state variables that determine the loading state (e.g. isLoading, isDataReady)

Example

const reasonAttributes: SkeletonSpanReasonAttributes = {
    context: 'ParentComponent',
    isLoading,
    isDataReady,
};

<MergeExpensesSkeleton reasonAttributes={reasonAttributes} />

Reference

Scope

  • Component path: src/components/Skeletons/MergeExpensesSkeleton.tsx
  • Usage sites to update: ~1 file

Activity

  1. sosek108 commented on Feb 27, 2026

    @sosek108
    Contributor
  2. hoangzinh commented on Mar 6, 2026

    @hoangzinh
    Contributor

    PR is on Prod

  3. hoangzinh commented on Mar 15, 2026

    @hoangzinh
    Contributor

    @youssef-lr can you re-open this issue for payment, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions