Skip to content

[Due for payment 2026-03-13] Add reasonAttributes to CardRowSkeleton usage sites #83404

Closed

Description

@MelvinBot

Problem

As part of #81683, we need to add reasonAttributes to all skeleton components so that Sentry spans carry structured metadata about why a loading indicator is visible. This helps engineers debug infinite skeleton loading states.

Solution

Add reasonAttributes to all usage sites of CardRowSkeleton (src/components/Skeletons/CardRowSkeleton.tsx).

At each usage site:

  1. Pass a reasonAttributes prop with a context string identifying the parent component (e.g. 'ParentComponent.ChildComponent')
  2. Include relevant boolean state variables that determine the loading state (e.g. isLoading, isDataReady)

Example

const reasonAttributes: SkeletonSpanReasonAttributes = {
    context: 'ParentComponent',
    isLoading,
    isDataReady,
};

<CardRowSkeleton reasonAttributes={reasonAttributes} />

Reference

Scope

  • Component path: src/components/Skeletons/CardRowSkeleton.tsx
  • Usage sites to update: ~3 files
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. sosek108 commented on Feb 27, 2026

    @sosek108
    Contributor

    PR ready for review #83694

  2. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 6, 2026
  3. changed the title [-]Add reasonAttributes to CardRowSkeleton usage sites[/-] [+][Due for payment 2026-03-13] Add reasonAttributes to CardRowSkeleton usage sites[/+] on Mar 6, 2026
  4. melvin-bot commented on Mar 6, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  5. melvin-bot commented on Mar 6, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.31-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-03-13. 🎊

  6. melvin-bot commented on Mar 6, 2026

    @melvin-bot

    Triggered auto assignment to @garrettmknight (Awaiting Payment)

  7. QichenZhu commented on Mar 10, 2026

    @QichenZhu
    Contributor

    I'm not due payment since I didn't review the PR.

  8. melvin-bot commented on Mar 13, 2026

    @melvin-bot

    Issue is ready for payment but no BZ is assigned. @mallenexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  9. melvin-bot commented on Mar 13, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @sosek108 does not require payment (Contractor)
    • Reviewer: @QichenZhu owed $250 via NewDot

    BugZero Checklist (@mallenexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions