Repository navigation
[Due for payment 2026-03-19] Add reasonAttributes to CardIconSkeleton usage sites #83403
Description
Problem
As part of #81683, we need to add reasonAttributes to all skeleton components so that Sentry spans carry structured metadata about why a loading indicator is visible. This helps engineers debug infinite skeleton loading states.
Solution
Add reasonAttributes to all usage sites of CardIconSkeleton (src/components/Skeletons/CardIconSkeleton.tsx).
At each usage site:
- Pass a
reasonAttributesprop with acontextstring identifying the parent component (e.g.'ParentComponent.ChildComponent') - Include relevant boolean state variables that determine the loading state (e.g.
isLoading,isDataReady)
Example
const reasonAttributes: SkeletonSpanReasonAttributes = {
context: 'ParentComponent',
isLoading,
isDataReady,
};
<CardIconSkeleton reasonAttributes={reasonAttributes} />Reference
- See PR #82927 as an example of how this was done for
ActivityIndicatorin image-loading contexts - Parent issue: Track loading state conditions in Sentry spans to debug infinite skeletons #81683
Scope
- Component path:
src/components/Skeletons/CardIconSkeleton.tsx - Usage sites to update: ~1 file
Activity
sosek108 commentedon Feb 27, 2026
PR ready for review
[-]Add reasonAttributes to CardIconSkeleton usage sites[/-][+][Due for payment 2026-03-19] Add reasonAttributes to CardIconSkeleton usage sites[/+]melvin-bot commentedon Mar 12, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 12, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.36-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-03-19. 🎊
melvin-bot commentedon Mar 12, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)youssef-lr commentedon Mar 14, 2026
No payment needed.