Skip to content

[BT-132] Migrate Reports - Core (Part 4) #83369

Description

@mjasikowski

Description

Current State:

  • 5 routes for report fields, flags, profiles, and workspace selection
  • These routes use backTo parameter for return navigation

Implementation:

  • Replace getRoute(..., backTo) with createDynamicRoute()
  • Add source screens to entryScreens array
  • Remove backTo parameter from route definitions
  • Test forward/back navigation

Scope

Routes (5):

Route Constant Path
EDIT_REPORT_FIELD_REQUEST r/:reportID/edit/policyField/:policyID/:fieldID
FLAG_COMMENT flag/:reportID/:reportActionID
PROFILE a/:accountID
PROFILE_AVATAR a/:accountID/avatar
NEW_REPORT_WORKSPACE_SELECTION new-report-workspace-selection

Usages

EDIT_REPORT_FIELD_REQUEST:

  • Search for usages in report field editing flow

FLAG_COMMENT:

  • Search for usages in comment flagging flow

PROFILE:

  • src/pages/ProfilePage.tsx (entry point)
  • Multiple components navigating to user profiles

PROFILE_AVATAR:

  • Search for usages in avatar viewing flow

NEW_REPORT_WORKSPACE_SELECTION:

  • src/pages/NewReportWorkspaceSelectionPage.tsx:110

Files to modify:

  • src/ROUTES.ts - Update route definitions
  • src/libs/Navigation/types.ts - Remove backTo from params
  • Components listed above

Migration Progress

  • EDIT_REPORT_FIELD_REQUEST
  • FLAG_COMMENT
  • PROFILE
  • PROFILE_AVATAR
  • NEW_REPORT_WORKSPACE_SELECTION
Issue OwnerCurrent Issue Owner: @mananjadhav

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

InternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions