Onboarding-Tasks are displayed in Concierge chat instead of #admins room

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.25-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176924/test-cases/55614645 https://test-management.browserstack.com/projects/2219752/folder/13176677/test-cases/41236545
Email or phone of affected tester (no customers): menew230211@gmail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: MacBook Air 15.7.4 Chrome
App Component: Other

Action Performed:

1. Sign up to ND with a new Gmail account without a +
2. Select the purpose "Track and budget expenses"
3. On the "Stay organized with a workspace" modal, click "Create workspace"
4. On the "Invite members" screen, enter another new gmail address
5. Navigate to the #admins room
6. Locate the onboarding task list

Expected Result:

Onboarding tasks are displayed in the #admins room

Actual Result:

Onboarding tasks are displayed in the Concierge chat instead of in #admins room. "Free trial" badge also appears in Concierge chat

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7086495_1771891071954.Tasks_in_Concierge.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

🔍 Investigation Summary

Classification: Not a bug - Test case expectations need updating
Causing PR: #82804 - "82244: Sign up - Still assign guide for Track users after created workspace" by @abbasifaizan70 (High confidence)

Recommendation: DEMOTE

This is not a bug. PR #82804 intentionally changed the behavior so that "Track and budget expenses" (TRACK_WORKSPACE) users now receive onboarding tasks in Concierge chat instead of the #admins room. This was the intended fix for issue #82244.

The regression test case needs to be updated to reflect the new expected behavior:

• Old expectation: Track users get tasks in #admins room
• New (correct) expectation: Track users get tasks in Concierge chat
• Actual behavior: Track users get tasks in Concierge chat ✓

Only "Manage my team's expenses" (MANAGE_TEAM) users should receive onboarding tasks in the #admins room with a guide.

Labels: Remove both DeployBlocker labels - this is not blocking the deploy. The regression test case expectations should be updated to match the new intended behavior.

📋 Detailed Analysis

Evidence

The reported issue describes the exact behavior that PR #82804 was designed to implement. From PR #82804's description:

"This PR limits 'post onboarding in #admins with a guide' to users who chose Manage my team's expenses (MANAGE_TEAM). Users who chose Track and budget expenses (TRACK_WORKSPACE) are no longer included in that path. For TRACK_WORKSPACE users, onboarding is now posted in the Concierge chat with Concierge as the actor."

The test steps in PR #82804 explicitly verify:

"Verify the onboarding content (welcome message, task list, 'Create a workspace' completed) appears in the Concierge chat, not in #admins."

Verification

PR #82804 modified src/libs/ReportUtils.ts, specifically the isPostingTasksInAdminsRoom function:

Before PR #82804:

return (
    engagementChoice !== undefined &&
    [CONST.ONBOARDING_CHOICES.MANAGE_TEAM, CONST.ONBOARDING_CHOICES.TRACK_WORKSPACE].includes(engagementChoice) &&
    (!currentUserEmail?.includes('+') || userHasPhonePrimaryEmail)
);

After PR #82804:

return engagementChoice !== undefined && 
       engagementChoice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM && 
       (!currentUserEmail?.includes('+') || userHasPhonePrimaryEmail);

This change explicitly removed TRACK_WORKSPACE from the list of choices that post to #admins room.

Root Cause

The regression test cases (TC 55614645 and 41236545) have not been updated to reflect the new expected behavior after PR #82804. The test expects tasks in #admins for Track users, but the correct behavior after PR #82804 is for tasks to appear in Concierge.