Repository navigation
[HOLD for payment 2022-03-31] Future dates in DOB date picker are not disabled. It is disabled for Incorporation Date - reported by @thesahindia #8151
Description
Activity
Triggered auto assignment to @mountiny (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.- changed the title
[-]Future dates in DOB date picker are not disabled. It is disabled for Incorporation Date[/-][+]Future dates in DOB date picker are not disabled. It is disabled for Incorporation Date - reported by @thesahindia[/+]on Mar 15, 2022 @luacmartins Coming from the Slack thread, there was not more people who chimed in. As you worked on the Forms overhaul, you probably have the best idea about how we want to proceed with the forms in future.
Would you say then we would want to enable future dates, but throw error? We would need to do the validation (if it does not exist yet internally in backend)
Although I feel like in this case we could go with disabling it in front end. We should still make sure we have validation steps that catch bugs or bad actors, but it seems like there should be no case when users will want to add future data, so so no reason to actually allow them to.
I can be persuaded differently though 😄
Triggered auto assignment to @jboniface (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.@luacmartins Perfect, thank you so much!
Proposal
need to pass
maximumDate={new Date()}inDatePicker
App/src/pages/ReimbursementAccount/IdentityForm.js
Lines 91 to 96 in 3696074
10 remaining items
Thanks @rushatgabhane!
@thesahindia Feel free to submit the PR.
Reacted by Sahil- changed the title
[-]Future dates in DOB date picker are not disabled. It is disabled for Incorporation Date - reported by @thesahindia[/-][+][HOLD for payment 2022-03-31] Future dates in DOB date picker are not disabled. It is disabled for Incorporation Date - reported by @thesahindia[/+]on Mar 30, 2022 There was an issue with the deploy comments, this should be applicable for payment on Thursday 🎉
@thesahindia & @rushatgabhane i think this is the job that upwork accidentally took down, I reposted it under a new link here
Reacted by SahilThanks!
Applied.
There is an option to set max date in date picker.
Solution - At the time of selecting date picker, just need to set max date in date picker. It will take maximum 2 hrs with testing.
@mohanbright sorry, but we have already hired someone for this job and the PR with the fix has been merged. Thanks for your interest though and I hope to see more of your proposals on some of our other open issues.
Reacted by Vit Horacek@jboniface Has this been paid and just not closed? Can we close?
nah, I was OOO and waiting for the job to be accepted.
Reacted by Vit Horacek
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
The future dates should be disabled for DOB date picker
Actual Result:
Future dates in DOB date picker are not disabled.
Workaround:
unknown
Platform:
Where is this issue occurring?
Version Number: 1.1.41-4
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screen.Recording.2022-03-04.at.7.39.42.PM.mov
Expensify/Expensify Issue URL:
Issue reported by: @thesahindia
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1646403860813759
View all open jobs on GitHub
this job