[Due for payment 2026-05-29] [$250] iOS - Room - App crashes when inviting member to room

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.11-17
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #80201
Email or phone of affected tester (no customers): sidnjosdnjdosijsojns@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: iPhone 15 Pro Max / iOS 26.2
App Component: Other

Action Performed:

Pre condition:

• member(s) are already invited to a room chat.

1. Launch Expensify app.
2. Open a room chat.
3. Tap on the header.
4. Tap Members.
5. Tap Invite member.
6. Invite anyone to the room.

Expected Result:

App will not crash.

Actual Result:

App crashes when inviting member to room.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7062913_1769871479145.80201_iOS.MP4

Bug7062913_1769871479145!Expensify-2026-01-31-225347.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022018297926265147864
• Upwork Job ID: 2018297926265147864
• Last Price Increase: 2026-02-09
• Automatic offers:
• abzokhattab | Contributor | 110455105

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022018297926265147864

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Krishna2323 (External)

[twinkle-react]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The iOS Expensify app crashes when inviting a user to an existing room chat because the app closes right after the invite is confirmed.

What is the root cause of that problem?

The earliest incorrect assumption is that report.participants is always a plain object in src/libs/actions/Report/index.ts inside buildInviteToRoomOnyxData. This assumption is wrong because report.participants can be null or undefined for some reports. The code spreads report.participants directly, which throws a runtime error when it is not an object, and this directly causes the crash.

// File: src/libs/actions/Report/index.ts
// Function: buildInviteToRoomOnyxData
const participantsAfterInvitation = inviteeAccountIDs.reduce(
    (reportParticipants: Participants, accountID: number) => {
        const participant: ReportParticipant = {
            notificationPreference: defaultNotificationPreference,
            role: CONST.REPORT.ROLE.MEMBER,
        };
        // eslint-disable-next-line no-param-reassign
        reportParticipants[accountID] = participant;
        return reportParticipants;
    },
    {...report.participants},
);

What changes do you think we should make in order to solve the problem?

We should ensure the code always treats report.participants as a plain object before spreading it. This is a small change in the shared action that builds the invite Onyx data.

// File: src/libs/actions/Report/index.ts
// Function: buildInviteToRoomOnyxData
const participantsAfterInvitation = inviteeAccountIDs.reduce(
    (reportParticipants: Participants, accountID: number) => {
        const participant: ReportParticipant = {
            notificationPreference: defaultNotificationPreference,
            role: CONST.REPORT.ROLE.MEMBER,
        };
        // eslint-disable-next-line no-param-reassign
        reportParticipants[accountID] = participant;
        return reportParticipants;
    },
    {...(report.participants ?? {})},
);

What alternative solutions did you explore? (Optional)

An alternative was to normalize report.participants earlier in the UI layer, such as in a HOC like withReportOrNotFound. This is weaker because it moves responsibility away from the shared action, increases the number of places that must be correct, and does not guarantee safety if the action is called from other paths.

[abbasifaizan70]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On iOS, the app crashes when inviting a member to a room who has already been invited but is still in a pending state (invite not yet processed). The app should prevent duplicate invitations and display an appropriate message.

What is the root cause of that problem?

The RoomInvitePage component only excludes current room participants from the invite list, but doesn't exclude pending invited members stored in reportMetadata.pendingChatMembers.

When a user invites someone, that person is added to pendingChatMembers with pendingAction: 'add'. If the user navigates back to the invite screen before the backend processes the invite, the pending member still appears in the selectable list. Re-inviting them creates duplicate pending entries, leading to inconsistent state and causing the iOS app to crash.

App/src/pages/RoomInvitePage.tsx

Lines 78 to 92 in 1712204

	// Any existing participants and Expensify emails should not be eligible for invitation
	const excludedUsers = useMemo(() => {
	const res = {
	...CONST.EXPENSIFY_EMAILS_OBJECT,
	};
	const visibleParticipantAccountIDs = Object.entries(report.participants ?? {})
	.filter(([, participant]) => participant && !isHiddenForCurrentUser(participant.notificationPreference))
	.map(([accountID]) => Number(accountID));
	for (const participant of getLoginsByAccountIDs(visibleParticipantAccountIDs)) {
	const smsDomain = addSMSDomainIfPhoneNumber(participant);
	res[smsDomain] = true;
	}
	return res;
	}, [report.participants]);

The current excludedUsers logic only considers report.participants:

What changes do you think we should make in order to solve the problem?

File: src/pages/RoomInvitePage.tsx

1. Add reportMetadata to Onyx subscriptions to access pendingChatMembers
2. Include pending members (with pendingAction: 'add') in the excludedUsers list alongside current participants

Changes:

// Add reportMetadata subscription
const [reportMetadata] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_METADATA}${report?.reportID}`, {canBeMissing: true});

// Update excludedUsers to include pending invites
const excludedUsers = useMemo(() => {
    const res = {
        ...CONST.EXPENSIFY_EMAILS_OBJECT,
    };
    const visibleParticipantAccountIDs = Object.entries(report.participants ?? {})
        .filter(([, participant]) => participant && !isHiddenForCurrentUser(participant.notificationPreference))
        .map(([accountID]) => Number(accountID));
    
    // Get pending invited members (not yet confirmed by backend)
    const pendingParticipantAccountIDs = (reportMetadata?.pendingChatMembers ?? [])
        .map((pendingMember) => Number(pendingMember?.accountID))
        .filter((accountID) => Number.isFinite(accountID));
    
    // Merge both current and pending participants
    const excludedAccountIDs = new Set([...visibleParticipantAccountIDs, ...pendingParticipantAccountIDs]);
    
    for (const participant of getLoginsByAccountIDs(Array.from(excludedAccountIDs))) {
        const smsDomain = addSMSDomainIfPhoneNumber(participant);
        res[smsDomain] = true;
    }

    return res;
}, [report.participants, reportMetadata?.pendingChatMembers]);

This ensures:

• Pending invitees don't appear in the selectable member list
• When searching for a pending invitee, the header shows "user is already a member" message
• No duplicate pending entries can be created
• The iOS crash is prevented

Demo

Screen.Recording.2026-02-02.at.6.04.02.PM.mov