Expense - Itemized violation is cleared only after opening the expense.

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.3.11-17
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #78410
Email or phone of affected tester (no customers): dreamnitethedragon+yydyd373@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Redminote 10S Android 13
App Component: User Settings

Action Performed:

1. Launch app
2. Create a workspace
3. Tap more features and enable rules
4. Create a manual expense with amount greater than ₹75 without category
5. Open the expense and note itemized violation is shown
6. Go to reports - expense and note itemized violation is displayed
7. Go to workspace settings and downgrade to collect workspace
8. Go to reports - expense and note itemized violation is still displayed
9. Go to inbox and open the expense
10. Go back to report and note violation is cleared

Expected Result:

Itemized violation must be auto cleared without opening the expense.

Actual Result:

Itemized violation is cleared only after opening the expense.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Itemized violation must be auto cleared without opening the expense when downgrading workspace from Control to Collect/Team.

What is the root cause of that problem?

When downgradeToTeam function is called, it only updates the policy type to TEAM but does not recalculate the violations for transactions in that workspace.

App/src/libs/actions/Policy/Policy.ts

Lines 5095 to 5136 in e8e0bf3

	function downgradeToTeam(policyID: string) {
	// This will be fixed as part of https://github.com/Expensify/Expensify/issues/507850
	// eslint-disable-next-line @typescript-eslint/no-deprecated
	const policy = getPolicy(policyID);
	const optimisticData: OnyxUpdate[] = [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `policy_${policyID}`,
	value: {
	isPendingDowngrade: true,
	type: CONST.POLICY.TYPE.TEAM,
	isAttendeeTrackingEnabled: null,
	},
	},
	];
	const successData: OnyxUpdate[] = [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `policy_${policyID}`,
	value: {
	isPendingDowngrade: false,
	},
	},
	];
	const failureData: OnyxUpdate[] = [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `policy_${policyID}`,
	value: {
	isPendingDowngrade: false,
	type: policy?.type,
	isAttendeeTrackingEnabled: policy?.isAttendeeTrackingEnabled,
	},
	},
	];
	const parameters: DowngradeToTeamParams = {policyID};
	API.write(WRITE_COMMANDS.DOWNGRADE_TO_TEAM, parameters, {optimisticData, successData, failureData});
	}

The itemized receipt required violation (CONST.VIOLATIONS.ITEMIZED_RECEIPT_REQUIRED) is only applicable for Control policies (checked via isControlPolicy in ViolationsUtils.getViolationsOnyxData). When downgrading, the policy type changes but violations are not recalculated, so stale violations remain until the user opens the expense (which triggers the server to return updated violations).

What changes do you think we should make in order to solve the problem?

We should use pushTransactionViolationsOnyxData in downgradeToTeam function to recalculate violations for all transactions in the workspace with the updated policy type. This is the same pattern used in other policy actions like enablePolicyTags, setPolicyRequiresTag, deleteWorkspaceCategories, etc.

--- a/src/libs/actions/Policy/Policy.ts
+++ b/src/libs/actions/Policy/Policy.ts
@@ -5095,6 +5095,10 @@ function downgradeToTeam(policyID: string) {
     // This will be fixed as part of https://github.com/Expensify/Expensify/issues/507850
     // eslint-disable-next-line @typescript-eslint/no-deprecated
     const policy = getPolicy(policyID);
+    const policyData = getPolicyDataForPushTransactionViolations(policyID);
+    if (!policyData) {
+        return;
+    }
     const optimisticData: OnyxUpdate[] = [
         {
             onyxMethod: Onyx.METHOD.MERGE,
@@ -5130,6 +5134,13 @@ function downgradeToTeam(policyID: string) {
         },
     ];

+    const onyxData = {optimisticData, successData, failureData};
+
+    pushTransactionViolationsOnyxData(onyxData, policyData, {
+        type: CONST.POLICY.TYPE.TEAM,
+        isAttendeeTrackingEnabled: null,
+    });
+
     const parameters: DowngradeToTeamParams = {policyID};

     API.write(WRITE_COMMANDS.DOWNGRADE_TO_TEAM, parameters, {optimisticData, successData, failureData});

What alternative solutions did you explore? (Optional)

1. Clear all violations when downgrading - This would be too aggressive as some violations may still be valid on Team workspaces.
2. Add a specific cleanup for itemized receipt violations only - This would be less maintainable as we'd need to add more cleanup logic for each Control-only violation type.

[getusha]

I don't think this is worth fixing

[melvin-bot]

@jponikarchuk, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.