Expenses - Pay options are not disabled when foreign currency expenses are created offline

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.11-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #78426
Email or phone of affected tester (no customers): sdjoisjnodjsojnsiodj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.1 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Go offline.
4. Create two expenses in foreign currency.
5. Open the report.
6. Click Submit and Approve.
   → Pay option is disabled because the created expenses are in foreign currency - Expected.
7. Select both expenses via checkbox.
8. Click More > Pay > Mark as paid.

Expected Result:

Pay options should be disabled when foreign currency expenses are created offline.

Actual Result:

Pay options are not disabled when foreign currency expenses are created offline.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7060781_1769649069610.6.mp4

View all open jobs on GitHub

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #78426

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

🔍 Investigation Summary

Classification: Frontend bug
Causing PR: #78426 - "Show Submit/Approve/Pay actions for selected transactions when all expenses are selected" by @cosmicvulpes (High confidence)
Related Issues: None identified

Recommendation: REVERT

The PR introduced bulk report-level actions (Submit/Approve/Pay) for selected transactions, but it does not properly validate that all selected transactions have compatible currencies for payment when expenses are created offline.

Labels: Keeping DeployBlockerCash (Frontend bug blocks App deploy). Removing DeployBlocker (no backend changes needed).

📋 Detailed Analysis

Evidence

PR #78426 added the ability to show report-level Pay actions when all expenses in a report are selected. The bug occurs because:

1. The shouldShowPayButton determination uses getCanIOUBePaid() which only checks a single transaction or undefined
2. When all transactions are selected for bulk payment, it should validate ALL selected transactions
3. Foreign currency expenses created offline (with pendingAction set) bypass the currency validation

Verification

The affected code is in src/components/MoneyReportHeader.tsx:

Line 394 - Only checks single transaction:

(onlyShowPayElsewhere = false) => canIOUBePaidAction(moneyRequestReport, chatReport, policy, bankAccountList, transaction ? [transaction] : undefined, onlyShowPayElsewhere)

Lines 862-877 - Uses this incomplete check for bulk actions:

const selectionModePaymentOptions = usePaymentOptions({
    currency: moneyRequestReport?.currency,  // Uses report currency, not individual transaction currencies
    shouldHidePaymentOptions: !shouldShowPayButton,  // Based on single transaction check
    isSelectedTransactionAction: true,
});

Root Cause

When determining payment eligibility for bulk actions, the code uses:

• transaction (singular) which is from transaction thread view, or undefined
• Not transactions (plural) which contains all report transactions

The fix needs to pass ALL transactions (not just one) to canIOUBePaid when calculating payment options for the bulk selection dropdown, and properly validate each transaction's currency and pending state.