[$250] Expense - Attendees section is shown when "Rules" feature is not enabled

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.3.9-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #79050
Email or phone of affected tester (no customers): dreamnitethedragon+yydyd373@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Redminote 10S Android 13
App Component: Money Requests

Action Performed:

1. Launch app
2. Login with new gmail account
3. Select manage my team expenses - (1-10 employees) and "other" to complete onboarding flow
4. Open workspace chat
5. Try to create a expense and in confirmation page note "Attendees" section is shown
6. Go to workspace settings - more features and note " Rules" feature is not enabled

Expected Result:

Attendees section must not be shown when "Rules" feature is not enabled.

Actual Result:

Attendees section is shown when "Rules" feature is not enabled.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7059417_1769531177625.Screenrecorder-2026-01-27-21-47-47-850.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022016195538942874152
• Upwork Job ID: 2016195538942874152
• Last Price Increase: 2026-03-31

Issue Owner

Current Issue Owner: @eVoloshchak

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022016195538942874152

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When creating an expense on a new workspace where the "Rules" feature is not enabled, the "Attendees" section is still shown in the confirmation page. The Attendees section should only be shown when the "Rules" feature is enabled, since Attendee Tracking is a sub-feature of Rules.

What is the root cause of that problem?

The root cause is in the shouldShowAttendees function in src/libs/TransactionUtils/index.ts:

App/src/libs/TransactionUtils/index.ts

Lines 562 to 570 in dba6afb

	/** Check if the receipt has the source file */
	function hasReceiptSource(transaction: OnyxInputOrEntry<Transaction>): boolean {
	return !!transaction?.receipt?.source;
	}
	function isDemoTransaction(transaction: OnyxInputOrEntry<Transaction>): boolean {
	return transaction?.comment?.isDemoTransaction ?? false;
	}

It does not check if policy?.areRulesEnabled is true. The "Attendee Tracking" setting is located under the "Rules" section in IndividualExpenseRulesSection.tsx, which means Attendee Tracking is a sub-feature of Rules.

When Rules is disabled, the Attendees section should not be shown regardless of the isAttendeeTrackingEnabled value.

What changes do you think we should make in order to solve the problem?

Update the shouldShowAttendees function in src/libs/TransactionUtils/index.ts to also check if Rules is enabled:

function shouldShowAttendees(iouType: IOUType, policy: OnyxEntry<Policy>): boolean {
    if ((iouType !== CONST.IOU.TYPE.SUBMIT && iouType !== CONST.IOU.TYPE.CREATE && iouType !== CONST.IOU.TYPE.TRACK) || !policy?.id || policy?.type !== CONST.POLICY.TYPE.CORPORATE) {
        return false;
    }

+   // Attendee Tracking is a sub-feature of Rules, so Rules must be enabled first
+   if (!policy?.areRulesEnabled) {
+       return false;
+   }
+
    // For backwards compatibility with Expensify Classic, we assume that Attendee Tracking is enabled by default on
    // Control policies if the policy does not contain the attribute
    return policy?.isAttendeeTrackingEnabled ?? true;
}

What alternative solutions did you explore? (Optional)

[MobileMage]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When creating an expense in a workspace, the "Attendees" section is shown in the expense confirmation page even when the "Rules" feature is not enabled in the workspace settings (More Features > Rules). The Attendees feature is a sub-feature of Rules, so it should only be visible when Rules is enabled.

What is the root cause of that problem?

The root cause is in the shouldShowAttendees function:

App/src/libs/TransactionUtils/index.ts

Lines 585 to 593 in 95c6b11

	function shouldShowAttendees(iouType: IOUType, policy: OnyxEntry<Policy>): boolean {
	if ((iouType !== CONST.IOU.TYPE.SUBMIT && iouType !== CONST.IOU.TYPE.CREATE && iouType !== CONST.IOU.TYPE.TRACK) || !policy?.id || policy?.type !== CONST.POLICY.TYPE.CORPORATE) {
	return false;
	}
	// For backwards compatibility with Expensify Classic, we assume that Attendee Tracking is enabled by default on
	// Control policies if the policy does not contain the attribute
	return policy?.isAttendeeTrackingEnabled ?? true;
	}

The function only checks if the policy is a Corporate policy and if isAttendeeTrackingEnabled is true (defaulting to true when undefined). However, it does NOT check if areRulesEnabled is true.

The Attendee Tracking toggle is part of the Rules feature UI, meaning it can only be configured when Rules is enabled. Therefore, the attendees section should only show when:

1. Rules feature is enabled (areRulesEnabled === true)
2. AND Attendee Tracking is enabled within Rules (isAttendeeTrackingEnabled is true)

The bug occurs because when a new workspace is created and Rules is disabled:

• areRulesEnabled is false or undefined
• isAttendeeTrackingEnabled is undefined
• The function returns undefined ?? true = true, incorrectly showing the Attendees section

What changes do you think we should make in order to solve the problem?

Add a check for areRulesEnabled in the shouldShowAttendees function. The function should return false early if Rules is not enabled, since Attendee Tracking is a sub-feature of Rules.

In src/libs/TransactionUtils/index.ts, modify the shouldShowAttendees function:

function shouldShowAttendees(iouType: IOUType, policy: OnyxEntry<Policy>): boolean {
    if ((iouType !== CONST.IOU.TYPE.SUBMIT && iouType !== CONST.IOU.TYPE.CREATE && iouType !== CONST.IOU.TYPE.TRACK) || !policy?.id || policy?.type !== CONST.POLICY.TYPE.CORPORATE) {
        return false;
    }

    // Attendee Tracking is a sub-feature of Rules, so Rules must be enabled first
    if (!policy?.areRulesEnabled) {
        return false;
    }

    // For backwards compatibility with Expensify Classic, we assume that Attendee Tracking is enabled by default on
    // Control policies if the policy does not contain the attribute
    return policy?.isAttendeeTrackingEnabled ?? true;
}

What alternative solutions did you explore? (Optional)

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Attendees section is shown when "Rules" feature is not enabled.

What is the root cause of that problem?

If the accounting is selected during onboarding, the workspace is upgraded to a control workspace. Because isAttendeeTrackingEnabled is undefined, we assume Attendees feature is enabled by default.

App/src/libs/TransactionUtils/index.ts

Lines 585 to 595 in a6bb5c3

	function shouldShowAttendees(iouType: IOUType, policy: OnyxEntry<Policy>): boolean {
	if ((iouType !== CONST.IOU.TYPE.SUBMIT && iouType !== CONST.IOU.TYPE.CREATE && iouType !== CONST.IOU.TYPE.TRACK) || !policy?.id || policy?.type !== CONST.POLICY.TYPE.CORPORATE) {
	return false;
	}
	// For backwards compatibility with Expensify Classic, we assume that Attendee Tracking is enabled by default on
	// Control policies if the policy does not contain the attribute
	return policy?.isAttendeeTrackingEnabled ?? true;
	}
	/**

But look like it's incorrect now. Let's see IndividualExpenseRulesSection here

App/src/pages/workspace/rules/IndividualExpenseRulesSection.tsx

Line 218 in a6bb5c3

const isAttendeeTrackingEnabled = policy?.isAttendeeTrackingEnabled ?? false;

What changes do you think we should make in order to solve the problem?

Update shouldShowAttendees to be consistent with IndividualExpenseRulesSection and we can remove the comment

return policy?.isAttendeeTrackingEnabled ?? false;

App/src/libs/TransactionUtils/index.ts

Lines 585 to 595 in a6bb5c3

	function shouldShowAttendees(iouType: IOUType, policy: OnyxEntry<Policy>): boolean {
	if ((iouType !== CONST.IOU.TYPE.SUBMIT && iouType !== CONST.IOU.TYPE.CREATE && iouType !== CONST.IOU.TYPE.TRACK) || !policy?.id || policy?.type !== CONST.POLICY.TYPE.CORPORATE) {
	return false;
	}
	// For backwards compatibility with Expensify Classic, we assume that Attendee Tracking is enabled by default on
	// Control policies if the policy does not contain the attribute
	return policy?.isAttendeeTrackingEnabled ?? true;
	}
	/**

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[abbasifaizan70]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Attendees section is shown when "Rules" feature is not enabled.

What is the root cause of that problem?

The decision to show Attendees is made in shouldShowAttendees(), which does not check whether the Rules feature is enabled. When Rules is off, isAttendeeTrackingEnabled is never set; we default it to true, so Attendees are shown anyway.

App/src/libs/TransactionUtils/index.ts

Lines 607 to 615 in 2abd327

	function shouldShowAttendees(iouType: IOUType, policy: OnyxEntry<Policy>): boolean {
	if ((iouType !== CONST.IOU.TYPE.SUBMIT && iouType !== CONST.IOU.TYPE.CREATE && iouType !== CONST.IOU.TYPE.TRACK) || !policy?.id || policy?.type !== CONST.POLICY.TYPE.CORPORATE) {
	return false;
	}
	// For backwards compatibility with Expensify Classic, we assume that Attendee Tracking is enabled by default on
	// Control policies if the policy does not contain the attribute
	return policy?.isAttendeeTrackingEnabled ?? true;
	}

Attendees (and "Require Attendees") live under Workspace Rules, so the section must be hidden when Rules is not enabled.

What changes do you think we should make in order to solve the problem?

Add a guard in shouldShowAttendees so we return false when Rules is not enabled, then keep the existing isAttendeeTrackingEnabled logic.

App/src/libs/TransactionUtils/index.ts

Lines 607 to 615 in 2abd327

	function shouldShowAttendees(iouType: IOUType, policy: OnyxEntry<Policy>): boolean {
	if ((iouType !== CONST.IOU.TYPE.SUBMIT && iouType !== CONST.IOU.TYPE.CREATE && iouType !== CONST.IOU.TYPE.TRACK) || !policy?.id || policy?.type !== CONST.POLICY.TYPE.CORPORATE) {
	return false;
	}
	// For backwards compatibility with Expensify Classic, we assume that Attendee Tracking is enabled by default on
	// Control policies if the policy does not contain the attribute
	return policy?.isAttendeeTrackingEnabled ?? true;
	}

function shouldShowAttendees(iouType: IOUType, policy: OnyxEntry<Policy>): boolean {
    if ((iouType !== CONST.IOU.TYPE.SUBMIT && iouType !== CONST.IOU.TYPE.CREATE && iouType !== CONST.IOU.TYPE.TRACK) || !policy?.id || policy?.type !== CONST.POLICY.TYPE.CORPORATE) {
        return false;
    }

    // Attendees feature is part of Workspace Rules - don't show when Rules is not enabled
    if (!policy?.areRulesEnabled) {
        return false;
    }

    // For backwards compatibility with Expensify Classic, we assume that Attendee Tracking is enabled by default on
    // Control policies if the policy does not contain the attribute
    return policy?.isAttendeeTrackingEnabled ?? true;
}

What alternative solutions did you explore? (Optional)

Defaulting isAttendeeTrackingEnabled to false (to match IndividualExpenseRulesSection) would also hide Attendees when Rules is off, but adding an explicit areRulesEnabled check keeps the rule "Attendees require Rules" in one place and matches how the feature is presented in the product.