[$250] Domains - Not here page opens after removing yourself as admin

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.6-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #79765
Email or phone of affected tester (no customers): applausetester+210102abc@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.1 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Log in as domain admin which is not primary contact.

1. Go to staging.new.expensify.com
2. Go to Workspaces.
3. Scroll to the bottom.
4. Tap applause.expensifail.com domain.
5. Go to Domain admins.
6. Tap on your own profile.
7. Tap Revoke access.
8. Tap Remove.

Expected Result:

User will be redirected to Workspaces page after removing themselves as admin.

Actual Result:

Not here page opens after removing themselves as admin.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7055394_1769072774874.12.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022014735920364075423
• Upwork Job ID: 2014735920364075423
• Last Price Increase: 2026-01-23
• Automatic offers:
• MobileMage | Contributor | 110313073

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @heyjennahay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MobileMage]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a domain admin removes their own admin access from a domain, they see a "Not here" error page instead of being redirected to the Workspaces page. The expected behavior is that after revoking their own admin access, the user should be automatically redirected to the Workspaces list page.

What is the root cause of that problem?

The root cause is that DomainInitialPage does not have a useEffect to navigate the user away when they lose admin access.

When the user clicks "Revoke access" to remove themselves as admin:

1. In DomainAdminDetailsPage.tsx (lines 65-66), the handleRevokeAdminAccess function calls:

   • revokeDomainAdminAccess(route.params.domainAccountID, route.params.accountID)
   • Navigation.dismissModal()

2. The dismissModal() closes the RHP (Right Hand Panel) containing DomainAdminDetailsPage, returning to the underlying DomainInitialPage.

3. In DomainInitialPage.tsx (lines 108-115), the page renders FullPageNotFoundView with shouldShow={!domain || !isAdmin}:

   <FullPageNotFoundView
       onBackButtonPress={() => Navigation.dismissModal()}
       onLinkPress={Navigation.goBackToHome}
       shouldShow={!domain || !isAdmin}
       ...
   >

4. Since the user is no longer an admin (the SHARED_NVP_PRIVATE_ADMIN_ACCESS Onyx key gets updated), isAdmin becomes false, and the "Not here" page is shown.

The problem is that DomainInitialPage only renders the "Not here" view but does NOT automatically navigate the user away. Other wrapper components like DomainNotFoundPageWrapper (lines 40-47) and AccessOrNotFoundWrapper (lines 200-206) have useEffect hooks that handle this scenario by navigating the user away when access is lost.

DomainNotFoundPageWrapper.tsx (lines 40-47):

useEffect(() => {
    if (shouldShowFullScreenLoadingIndicator || (domain && isAdmin)) {
        return;
    }
    Navigation.dismissModal();
}, [domain, isAdmin, shouldShowFullScreenLoadingIndicator]);

But DomainInitialPage doesn't use DomainNotFoundPageWrapper - it directly renders FullPageNotFoundView without any automatic navigation on access loss.

What changes do you think we should make in order to solve the problem?

Add a useEffect in DomainInitialPage.tsx to navigate the user to the Workspaces list page when they lose admin access, similar to how DomainNotFoundPageWrapper handles this case.

File: /src/pages/domain/DomainInitialPage.tsx

Add a useEffect after the existing hooks (around line 93):

+    useEffect(() => {
+        if (domain && isAdmin) {
+            return;
+        }
+
+        Navigation.goBack(ROUTES.WORKSPACES_LIST.route);
+    }, [domain, isAdmin]);
+
     return (
         <ScreenWrapper

This approach:

1. Detects when the user loses admin access (either !domain or !isAdmin)
2. Navigates back to the Workspaces list page using Navigation.goBack(ROUTES.WORKSPACES_LIST.route), which is consistent with other navigation patterns in this page (line 118)

What alternative solutions did you explore? (Optional)

[dmkt9]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Not here page opens after removing themselves as admin.

What is the root cause of that problem?

isCurrentUserPrimaryContact has the value false, so the "revoke admin access" button is not disabled.

App/src/pages/domain/Admins/DomainAdminDetailsPage.tsx

Line 48 in 6e6f87c

const isCurrentUserPrimaryContact = primaryContact === memberLogin;

This is because primaryContact here has the value undefined.

App/src/pages/domain/Admins/DomainAdminDetailsPage.tsx

Lines 29 to 32 in 6e6f87c

	const [primaryContact] = useOnyx(`${ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_DOMAIN_MEMBER}${domainAccountID}`, {
	selector: domainSettingsPrimaryContactSelector,
	canBeMissing: true,
	});

What changes do you think we should make in order to solve the problem?

We should fallback to the primaryContact value in the account:

+ const primaryContactFromAccountSelector = (account: OnyxEntry<Account>) => account?.primaryLogin;

App/src/pages/domain/Admins/DomainAdminDetailsPage.tsx

Line 33 in 6e6f87c

+    const [primaryContactFromAccount] = useOnyx(ONYXKEYS.ACCOUNT, {
+        selector: primaryContactFromAccountSelector,
+        canBeMissing: true,
+    });

App/src/pages/domain/Admins/DomainAdminDetailsPage.tsx

Line 48 in 6e6f87c

const isCurrentUserPrimaryContact = primaryContact === memberLogin;

    const isCurrentUserPrimaryContact = (primaryContact ?? primaryContactFromAccount) === memberLogin;

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022014735920364075423

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Krishna2323 (External)

[github-actions]

⚠️ @M00rish Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.