[$250] Reports - Unable to save a search after applying "Group By" filter.

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.0.0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-2923/folder/13176922/41237510/1121356114
Email or phone of affected tester (no customers): ibellicotest+2250@gmail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Motorola MotoG60 / Android 12 (Hybrid app)
App Component: Search

Action Performed:

1. Open the Expensify app.
2. Navigate to "Reports" > "Expenses"
3. Tap on "Filters"
4. Apply any filter except "Group By"
5. Note that there is a "Save Search" button in the filters settings.
6. Reset the applied filter.
7. Tap on "Group By" and select any option. (For example: From")
8. Save the filter.
9. Note that there is no "Save Search" button in the filters settings.

Expected Result:

"Save Search" button should be present in the filters settings page after applying any filter.

Actual Result:

"Save Search" button is not present in the filters settings page after applying the "Group By" filter.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022014474227316753419
• Upwork Job ID: 2014474227316753419
• Last Price Increase: 2026-01-22
• Automatic offers:
• daledah | Contributor | 110231688

Issue Owner

Current Issue Owner: @eVoloshchak

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Save Search" button is not present in the filters settings page after applying the "Group By" filter.

What is the root cause of that problem?

The root cause is in the isCannedSearchQuery function in src/libs/SearchQueryUtils.ts.

The "Save Search" button visibility is controlled by displaySearchButton which is set to:

App/src/pages/Search/AdvancedSearchFilters.tsx

Line 631 in 98a3245

const displaySearchButton = queryJSON && !isCannedSearchQuery(queryJSON);

App/src/libs/SearchQueryUtils.ts

Lines 1331 to 1336 in 98a3245

	function isCannedSearchQuery(queryJSON: SearchQueryJSON) {
	const selectedColumns = queryJSON.columns ?? [];
	const defaultColumns = Object.values(CONST.SEARCH.TYPE_DEFAULT_COLUMNS.EXPENSE_REPORT);
	const hasCustomColumns = !arraysEqual(defaultColumns, selectedColumns) && selectedColumns.length > 0;
	return !queryJSON.filters && !queryJSON.policyID && !queryJSON.status && !hasCustomColumns;
	}

It does not check for groupBy. When a user applies only the "Group By" filter, isCannedSearchQuery still returns true (treating it as a canned/default query), which causes displaySearchButton to be false.

What changes do you think we should make in order to solve the problem?

Update the function to also check for groupBy:

    return !queryJSON.filters && !queryJSON.policyID && !queryJSON.status && !queryJSON.groupBy && !hasCustomColumns;

App/src/libs/SearchQueryUtils.ts

Lines 1331 to 1336 in 98a3245

	function isCannedSearchQuery(queryJSON: SearchQueryJSON) {
	const selectedColumns = queryJSON.columns ?? [];
	const defaultColumns = Object.values(CONST.SEARCH.TYPE_DEFAULT_COLUMNS.EXPENSE_REPORT);
	const hasCustomColumns = !arraysEqual(defaultColumns, selectedColumns) && selectedColumns.length > 0;
	return !queryJSON.filters && !queryJSON.policyID && !queryJSON.status && !hasCustomColumns;
	}

Note: we should do the same with other fields that have the same problem

What alternative solutions did you explore? (Optional)

An alternative would be to modify the displaySearchButton logic in AdvancedSearchFilters.tsx to explicitly check for groupBy. However, fixing it at the source (isCannedSearchQuery) is more appropriate since this function is specifically designed to determine if a query is customized, and groupBy is a valid customization that should be considered.

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[dmkt9]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Save Search" button is not present in the filters settings page after applying the "Group By" filter.

What is the root cause of that problem?

1. The Save button does not appear because displaySearchButton === false.
   

   App/src/pages/Search/AdvancedSearchFilters.tsx

   Line 631 in 7d00137

   const displaySearchButton = queryJSON && !isCannedSearchQuery(queryJSON);

2. This happens because we still treat groupBy with a value as a canned query.
   

   App/src/libs/SearchQueryUtils.ts

   Line 1335 in 7d00137

   return !queryJSON.filters && !queryJSON.policyID && !queryJSON.status && !hasCustomColumns;

What changes do you think we should make in order to solve the problem?

We need to review all usages of buildCannedSearchQuery to ensure the conditions in isCannedSearchQuery are checked appropriately.
After reviewing everything, we should update the condition as follows:

    // Check whether it could be a viewTransactions canned query
    const isViewTransactionsSearchQuery = queryJSON.type === CONST.SEARCH.DATA_TYPES.EXPENSE && queryJSON.flatFilters?.every((item) => item.key === 'cardID' || item.key === 'expenseType');
    return !queryJSON.filters && !queryJSON.policyID && !queryJSON.status && !queryJSON.groupBy && !hasCustomColumns && !isViewTransactionsSearchQuery;

App/src/libs/SearchQueryUtils.ts

Line 1335 in 7d00137

return !queryJSON.filters && !queryJSON.policyID && !queryJSON.status && !hasCustomColumns;

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

@stephanieelliott Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@stephanieelliott 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022014474227316753419

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)