[Due for payment 2026-01-29] [$250] Expense - Remove hold message appears each time held expense is moved to different report

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.86-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-2487/folder/13176730/41237112/1089918497
Email or phone of affected tester (no customers): sdjnoisdjoisjdsoidj@gmail.comd
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Mac 26.1 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create an expense.
4. Open the expense report.
5. Click More > Hold.
6. Enter reason and save it.
7. Click Report field.
8. Click Create report.
9. Open the new report.

Expected Result:

Remove hold message will not appear when the held expense is moved to different report.

Actual Result:

Remove hold message appears each time held expense is moved to different report.
The expense is still held despite the message.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022008661516630610760
• Upwork Job ID: 2008661516630610760
• Last Price Increase: 2026-01-13

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove hold message appears each time held expense is moved to different report

What is the root cause of that problem?

We are adding unhold action below. It was originally added to show remove hold system message when an expense is moved to selfDM. But since we are not checking if are moving the expense to selfDM the remove hold system message is also displayed when we move the transaction to another expense report.

App/src/libs/actions/Transaction.ts

Lines 1209 to 1214 in 589574c

	if (isOnHold(transaction)) {
	const unHoldAction = buildOptimisticUnHoldReportAction();
	optimisticData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${transactionThreadReportID}`,
	value: {[unHoldAction.reportActionID]: unHoldAction},

What changes do you think we should make in order to solve the problem?

We should check if are are moving the expense to selfDM before we add the remove hold report action

        if (isOnHold(transaction) && isUnreported) {
            const unHoldAction = buildOptimisticUnHoldReportAction();

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[paulnjs]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a held expense is moved to a different report, a “hold removed” message appears every time. However, the expense itself remains held.

What is the root cause of that problem?

In PR #70593, logic was added to remove the hold status when moving an expense to the user’s self DM. During implementation, the logic was applied broadly without checking whether the destination report is actually a self DM.

As a result, the hold-removal messaging is triggered even when the expense is moved to other types of reports, where the hold should not be removed.

• App/src/libs/actions/Transaction.ts

  Line 864 in d9b7219

  hold: null,

• App/src/libs/actions/Transaction.ts

  Lines 1208 to 1209 in d9b7219

  	// Build unhold report action
  	if (isOnHold(transaction)) {

What changes do you think we should make in order to solve the problem?

We should only apply the hold-removal logic when the transaction is being moved to an unreported (self DM) report.

Specifically, gate the following logic behind an isUnreported check:

• App/src/libs/actions/Transaction.ts

  Line 864 in d9b7219

  hold: null,

• App/src/libs/actions/Transaction.ts

  Lines 1208 to 1209 in d9b7219

  	// Build unhold report action
  	if (isOnHold(transaction)) {

This ensures that the “hold removed” message and state change only occur in the intended scenario.

What alternative solutions did you explore? (Optional)

[melvin-bot]

@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mallenexpensify]

Strange, it looks like automation is failing. If a C+ is assigned, 👀 plz, this is what I see after following the steps in the OP.

[etCoderDysto]

Hi @mallenexpensify I think the automation failed to add a C+.

[truph01]

I can take over it as C+

[situchan]

removing External and adding back might help