[Due for payment 2026-01-15] [Due for payment 2026-01-07] [$250] Reports page - The App crashes when switching from `withdrawal-id` grouping to any other grouping via the dropdown

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.85-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @JS00001
Slack conversation (hyperlinked to channel name): #expensify_bugs

Action Performed:

Prerequisites: Need using account with a lot of withdrawal-id expenses

1. Go to https://staging.new.expensify.com/
2. Navigate to Reports > in Search type:expense group-by:withdrawal-id
3. Click "Group by" filter > switch the from withdrawal-id to from > Apply

Expected Result:

User can switch from withdrawal-id to from

Actual Result:

The app crashes

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Recording.3544.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022003109092606784237
• Upwork Job ID: 2003109092606784237
• Last Price Increase: 2025-12-22
• Automatic offers:
• linhvovan29546 | Reviewer | 109902138
• daledah | Contributor | 109902140

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[abbasifaizan70]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The app crashes when switching the "Group by" filter from "withdrawal-id" to "from" (or any other groupBy value).

What is the root cause of that problem?

The isSearchDataLoaded function in App/src/libs/SearchUIUtils.ts only checks if the type and status match between the search results and the current query. It does not verify that the groupBy parameter also matches.

This causes a race condition:

1. User changes groupBy from "withdrawal-id" to "from"
2. The queryJSON is updated with the new groupBy value
3. The search results still contain old data (grouped by withdrawal-id)
4. isSearchDataLoaded returns true because it only checks type and status
5. The component tries to process withdrawal-id grouped data using the "from" groupBy logic
6. The getMemberSections function expects data with accountID properties
7. But it receives SearchWithdrawalIDGroup objects with entryID and accountNumber properties instead
8. This causes a crash when accessing undefined properties

Current code:

https://github.com/Expensify/App/blob/main/src/libs/SearchUIUtils.ts#L2884-L2895

function isSearchDataLoaded(searchResults: SearchResults | undefined, queryJSON: SearchQueryJSON | undefined) {
    const {status} = queryJSON ?? {};

    const sortedSearchResultStatus = !Array.isArray(searchResults?.search?.status)
        ? searchResults?.search?.status?.split(',').sort().join(',')
        : searchResults?.search?.status?.sort().join(',');
    const sortedQueryJSONStatus = Array.isArray(status) ? status.sort().join(',') : status;
    const isDataLoaded = searchResults?.data !== undefined && searchResults?.search?.type === queryJSON?.type && sortedSearchResultStatus === sortedQueryJSONStatus;
    // ❌ Missing check: groupBy is not validated

    return isDataLoaded;
}

What changes do you think we should make in order to solve the problem?

1. Add groupBy property to SearchResultsInfo type

https://github.com/Expensify/App/blob/main/src/types/onyx/SearchResults.ts#L39-L70

type SearchResultsInfo = {
    offset: number;
    type: SearchDataTypes;
    status: SearchStatus;
    groupBy?: string;  // ✅ Add this property
    hasMoreResults: boolean;
    hasResults: boolean;
    isLoading: boolean;
    count?: number;
    total?: number;
    currency?: string;
};

2. Create helper function to detect groupBy from data structure

https://github.com/Expensify/App/blob/main/src/libs/SearchUIUtils.ts#L2884

Since the backend doesn't return groupBy, we need to detect it from the data structure:

function detectGroupByFromData(data: SearchResults['data'] | undefined): SearchGroupBy | null | undefined {
    if (!data) {
        return undefined;
    }

    let hasAnyData = false;
    let hasGroupEntries = false;

    for (const key in data) {
        if (key === 'personalDetailsList') {
            continue;
        }

        hasAnyData = true;

        if (isGroupEntry(key)) {
            hasGroupEntries = true;
            const groupData = data[key] as SearchMemberGroup | SearchCardGroup | SearchWithdrawalIDGroup;

            // Check for withdrawal ID group (has entryID and accountNumber)
            if ('entryID' in groupData && 'accountNumber' in groupData) {
                return CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID;
            }

            // Check for card group (has cardID)
            if ('cardID' in groupData) {
                return CONST.SEARCH.GROUP_BY.CARD;
            }

            // Check for member group (has accountID but no cardID or entryID)
            if ('accountID' in groupData) {
                return CONST.SEARCH.GROUP_BY.FROM;
            }
        }
    }

    // If there's data but no group entries, return null (ungrouped search)
    if (hasAnyData && !hasGroupEntries) {
        return null;
    }

    // No data yet
    return undefined;
}

3. Update isSearchDataLoaded function

https://github.com/Expensify/App/blob/main/src/libs/SearchUIUtils.ts#L2917

function isSearchDataLoaded(searchResults: SearchResults | undefined, queryJSON: SearchQueryJSON | undefined) {
    const {status, groupBy} = queryJSON ?? {};

    const sortedSearchResultStatus = !Array.isArray(searchResults?.search?.status)
        ? searchResults?.search?.status?.split(',').sort().join(',')
        : searchResults?.search?.status?.sort().join(',');
    const sortedQueryJSONStatus = Array.isArray(status) ? status.sort().join(',') : status;

    // Basic type and status check
    const basicMatch = searchResults?.data !== undefined && searchResults?.search?.type === queryJSON?.type && sortedSearchResultStatus === sortedQueryJSONStatus;

    if (!basicMatch) {
        return false;
    }

    // Detect the groupBy from the data structure if backend doesn't provide it
    const detectedGroupBy = detectGroupByFromData(searchResults?.data);
    const dataGroupBy = searchResults?.search?.groupBy ?? detectedGroupBy;

    // If we can't detect groupBy (returns undefined), the data is empty
    // Empty data is safe to display - no crash risk
    if (detectedGroupBy === undefined) {
        return true;
    }

    // Verify groupBy matches
    const normalizedQueryGroupBy = groupBy ?? null;
    const normalizedDataGroupBy = dataGroupBy ?? null;

    return normalizedDataGroupBy === normalizedQueryGroupBy;
}

What alternative solutions did you explore? (Optional)

None

Demo

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022003109092606784237

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @linhvovan29546 (External)

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The app crashes

What is the root cause of that problem?

In getMemberSections and getCardSections, the code accessed data.personalDetailsList[accountID] without checking if personalDetailsList exists. When switching groupBy, personalDetailsList can be undefined, causing a crash.

App/src/libs/SearchUIUtils.ts

Lines 1912 to 1913 in 5685a5f

	const cardGroup = data[key] as SearchCardGroup;
	const personalDetails = data.personalDetailsList[cardGroup.accountID];

App/src/libs/SearchUIUtils.ts

Lines 1871 to 1872 in 5685a5f

	const memberGroup = data[key] as SearchMemberGroup;
	const personalDetails = data.personalDetailsList[memberGroup.accountID];

What changes do you think we should make in order to solve the problem?

We should add optional chaining and a fallback to emptyPersonalDetails in both functions like we did with other functions here, here, ...

     const personalDetails = data.personalDetailsList?.[memberGroup.accountID] ?? emptyPersonalDetails;

App/src/libs/SearchUIUtils.ts

Lines 1871 to 1872 in 5685a5f

	const memberGroup = data[key] as SearchMemberGroup;
	const personalDetails = data.personalDetailsList[memberGroup.accountID];

     const personalDetails = data.personalDetailsList?.[cardGroup.accountID] ?? emptyPersonalDetails;

App/src/libs/SearchUIUtils.ts

Lines 1912 to 1913 in 5685a5f

	const cardGroup = data[key] as SearchCardGroup;
	const personalDetails = data.personalDetailsList[cardGroup.accountID];

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[linhvovan29546]

Thanks for the proposals I think @daledah's proposal is correct. Since personalDetailsList is can be undefinedbut the current type doesn't allow it, so i think we should update the personalDetailsList type to support undefined as well. This will help catch the crash earlier.

App/src/types/onyx/SearchResults.ts

Line 301 in ff71123

Record<typeof ONYXKEYS.PERSONAL_DETAILS_LIST, Record<string, PersonalDetails>> &

Record<typeof ONYXKEYS.PERSONAL_DETAILS_LIST, Record<string, PersonalDetails> | undefined> &

🎀 👀 🎀 C+ reviewed