[Due for payment 2025-12-31] Can't move per diem expense modal cannot be dismissed by clicking outside the modal

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.85-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory #77923
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Windows 11 / Chrome, iOS 15.8.3 / iPhone 7 Plus
App Component: Money Requests

Action Performed:

Precondition:

• At least 2 workspaces with per diem enabled (with different rates)
• A few per diem expenses were created on both workspaces

1. Login to https://staging.new.expensify.com/
2. Go to Reports > Expenses
3. Select a per diem expense (e.g. from PD 2)
4. Click "X selected" > Move expense
5. Click one of the reports from different workspace (e.g. PD 1)
6. Verify that a modal with "You can't move per diem expenses to reports on other workspaces, because the per diem rates may differ between workspaces" message appears
7. Click outside the Can't move per diem expense modal

Expected Result:

Can't move per diem expense modal will be dismissed by clicking outside the modal

Actual Result:

Can't move per diem expense modal cannot be dismissed by clicking outside the modal

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

Germany-per-diem.csv

Finland-per-diem.csv

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Eskalifer1]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Can't move per diem expense modal cannot be dismissed by clicking outside the modal

What is the root cause of that problem?

We are not passing onCancel here:

App/src/pages/iou/request/step/IOURequestEditReportCommon.tsx

Lines 341 to 348 in 251ab97

	<ConfirmModal
	isVisible={perDiemWarningModalVisible}
	onConfirm={hidePerDiemWarningModal}
	title={translate('iou.moveExpenses', {count: transactionIDs?.length ?? 1})}
	prompt={translate('iou.moveExpensesError')}
	confirmText={translate('common.buttonConfirm')}
	shouldShowCancelButton={false}
	/>

What changes do you think we should make in order to solve the problem?

Pass it:

 onCancel={hidePerDiemWarningModal}

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[parasharrajat]

Not really a deploy blocker. @youssef-lr.

[parasharrajat]

Do we need this @cristipaval?