[Due for payment 2026-01-20] [$250] Report - Incorrect total amount displayed on report after splitting an expense while offline

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.84-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-2432/folder/13176791/41237176/1084294746
Email or phone of affected tester (no customers): ibellicotest+2230@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Motorola MotoG60 / Android 12 / Chrome ( mWeb / Hybrid app) - Windows 11 / Chrome
App Component: Money Requests

Action Performed:

Prerequisite: Account has at least one workspace.

1. Open the staging.new.expensify.com website.
2. Open any workspace chat.
3. Create two manual expenses.
4. Open the report of the just created expenses.
5. Turn off internet connection.
6. Select any of the expenses.
7. Click on the dropdown menu and select "Split"
8. Save the created splits.
9. Once redirected to report, note that total amount shows only the splits amount and not the amount of all the expenses.
10. Turn on internet connection.
11. Note that amount reflected is now correct.

Expected Result:

Total amount on report, should display the amount of all the expenses and not only the splits, after splitting an expense offline.

Actual Result:

After splitting an expense offline in a report with other expenses, total amount only shows the splits amount.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7033853_1766164999432.Split_Off.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022002902825981528609
• Upwork Job ID: 2002902825981528609
• Last Price Increase: 2026-01-05

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When an expense is split while offline in a report that already has other expenses, the report total temporarily drops to only the split amounts instead of showing the full total for all expenses.

What is the root cause of that problem?

While computing optimistic totals for split expenses, we built reportTotals starting from zero and subtracted each split amount. When the split was saved offline, the parent report total was replaced with only the split sum, ignoring the existing report total until the server corrected it.

App/src/libs/actions/IOU.ts

Lines 14772 to 14782 in 2157c12

	const optimisticData = [] as OnyxUpdate[];
	// The split transactions can be in different reports, so we need to calculate the total for each report.
	const reportTotals = new Map<string, number>();
	for (const expense of splitExpenses) {
	if (expense.reportID) {
	const currentTotal = reportTotals.get(expense.reportID) ?? 0;
	reportTotals.set(expense.reportID, currentTotal - (expense.amount ?? 0));
	}
	}

What changes do you think we should make in order to solve the problem?

Update the optimistic totals map with the current expense report total, then apply only the delta from the split so other expenses remain counted offline, and keep other involved reports at their existing totals. Updated code:

    const reportTotals = new Map<string, number>();
    const expenseReportID = expenseReport?.reportID;

    if (expenseReportID) {
        const expenseReportKey = `${ONYXKEYS.COLLECTION.REPORT}${expenseReportID}`;
        const expenseReportTotal = allReportsList?.[expenseReportKey]?.total ?? expenseReport?.total ?? 0;
        reportTotals.set(expenseReportID, expenseReportTotal - changesInReportTotal);
    }

    for (const expense of splitExpenses) {
        const splitExpenseReportID = expense.reportID;
        if (!splitExpenseReportID || reportTotals.has(splitExpenseReportID)) {
            continue;
        }

        const splitExpenseReport = allReportsList?.[`${ONYXKEYS.COLLECTION.REPORT}${splitExpenseReportID}`];
        reportTotals.set(splitExpenseReportID, splitExpenseReport?.total ?? 0);
    }

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After splitting an expense offline in a report with other expenses, total amount only shows the splits amount.

What is the root cause of that problem?

The reportTotals calculation in updateSplitTransactions started from 0 and subtracted split amounts, producing negative values. These were used directly as newReportTotal, overwriting the report total incorrectly.

App/src/libs/actions/IOU.ts

Lines 14777 to 14784 in 89c1038

	// The split transactions can be in different reports, so we need to calculate the total for each report.
	const reportTotals = new Map<string, number>();
	for (const expense of splitExpenses) {
	if (expense.reportID) {
	const currentTotal = reportTotals.get(expense.reportID) ?? 0;
	reportTotals.set(expense.reportID, currentTotal - (expense.amount ?? 0));
	}
	}

What changes do you think we should make in order to solve the problem?

We should:

• Initialize reportTotals with each report's current total (not 0).
• When creating new splits, if splits go back to the same expense report, remove the original transaction amount from the total.
• Add split amounts to the appropriate report totals.

 const reportTotals = new Map<string, number>();
    const reportsWithSplits = new Set<string>();
    for (const expense of splitExpenses) {
        if (expense.reportID && !reportTotals.has(expense.reportID)) {
            const report = getReportOrDraftReport(expense.reportID);
            reportTotals.set(expense.reportID, report?.total ?? 0);
            reportsWithSplits.add(expense.reportID);
        }
    }

    if (isCreationOfSplits && expenseReport?.reportID && originalTransaction && reportsWithSplits.has(expenseReport.reportID)) {
        const originalTransactionDetails = getTransactionDetails(originalTransaction);
        const currentExpenseReportTotal = reportTotals.get(expenseReport.reportID) ?? 0;
        // For expense reports, amounts are stored as negative values, so we add the original amount to remove it
        reportTotals.set(expenseReport.reportID, currentExpenseReportTotal + (originalTransactionDetails?.amount ?? 0));
    }

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Incorrect total amount displayed on report after splitting an expense while offline

What is the root cause of that problem?

When splitting an expense, current logic calculates a reportTotals map to determine the new total for each report. When map was initialized from 0 and only accounted for the split expenses, completely ignoring:

• The original transaction that was being split (which needs to be subtracted)
• Other existing expenses in the report

What changes do you think we should make in order to solve the problem?

We should add logic to initialize the reportTotals map with the current report's total before calculating split totals, but only when creating splits for the first time isCreationOfSplits is true

if (isCreationOfSplits && expenseReport?.reportID) {
    const currentReportTotal = expenseReport.total ?? 0;
    const originalAmount = originalTransaction?.amount ?? 0;
    // Start with current total, then subtract the original transaction amount
    reportTotals.set(expenseReport.reportID, currentReportTotal + originalAmount);
}

here

App/src/libs/actions/IOU.ts

Lines 14774 to 14780 in 36b14f3

	const reportTotals = new Map<string, number>();
	for (const expense of splitExpenses) {
	if (expense.reportID) {
	const currentTotal = reportTotals.get(expense.reportID) ?? 0;
	reportTotals.set(expense.reportID, currentTotal - (expense.amount ?? 0));
	}
	}

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022002902825981528609

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)