Duplicate - The menu doesn't closes immediately after duplicating the expense

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.82-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #77343
Email or phone of affected tester (no customers): testpayment935@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Windows 11 pro /Chrome
App Component: Workspace Settings

Action Performed:

1. Navigate to staging.new.expensify.com
2. Log in using Track expense option
3. Go to self DM and create expense
4. Open the expense and click More
5. Click Duplicate option

Expected Result:

The menu should closes immediately

Actual Result:

The menu doesn't closes immediately in self DM page and in expanded RHP (expense report page)

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @brianlee-expensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Duplicate - The menu doesn't closes immediately after duplicating the expense

What is the root cause of that problem?

The duplicate action in MoneyRequestHeader has shouldCloseModalOnSelect: false, which prevents the menu from closing after duplicating an expense

App/src/components/MoneyRequestHeader.tsx

Line 414 in 894cbc2

shouldCloseModalOnSelect: false,

What changes do you think we should make in order to solve the problem?

I think it's expected to see the menu after duplicating the expense, but if we want to close it immediately, we can remove the shouldCloseModalOnSelect: false prop

App/src/components/MoneyRequestHeader.tsx

Lines 401 to 415 in 894cbc2

	[CONST.REPORT.SECONDARY_ACTIONS.DUPLICATE]: {
	text: isDuplicateActive ? translate('common.duplicate') : translate('common.duplicated'),
	icon: isDuplicateActive ? Expensicons.ReceiptMultiple : Expensicons.CheckmarkCircle,
	value: CONST.REPORT.SECONDARY_ACTIONS.DUPLICATE,
	onSelected: () => {
	if (!isDuplicateActive || !transaction) {
	return;
	}
	temporarilyDisableDuplicateAction();
	duplicateTransaction([transaction]);
	},
	shouldCloseModalOnSelect: false,
	},

What alternative solutions did you explore? (Optional)

Create a ref for the ButtonWithDropdownMenu component and use useEffect to close the menu when isDuplicateActive changes from false to true

[jjcoffee]

Yes, this is expected for now. The menu should only close immediately in the case of duplicating an expense where there are no other expenses, because in this case we navigate to a different view (this is to handle #77289).