Expense - Missing Add expense button when report is created offline on instant submission

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.78-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #75792
Email or phone of affected tester (no customers): siodjosdinjosjsoinjso@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Mac 26.1 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Submission frequency is Instantly.
• Disable Add approvals and Make or track payments.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Go offline.
4. Click + > Create report.

Expected Result:

Add expense button will be shown when report is created offline.

Actual Result:

Add expense button is missing when report is created offline when workspace is on instant submission.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7028286_1765578839592.6.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[marcochavezf]

Seems this is coming from #75792 cc @FitseTLT @brunovjk @AndrewGable

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Missing Add expense button when report is created offline on instant submission

What is the root cause of that problem?

When creating a report offline with instant submission enabled, the app set the report state to SUBMITTED instead of OPEN. The "Add expense" button logic checks if the report is OPEN, and because it was SUBMITTED, it hid the button. This mismatch happened because getExpenseReportStateAndStatus applied instant submit rules even to empty reports, while the backend always returns OPEN for new reports.

App/src/libs/ReportUtils.ts

Lines 6833 to 6838 in 3c5a961

	if (isInstantSubmitEnabledLocal) {
	return {
	stateNum: CONST.REPORT.STATE_NUM.SUBMITTED,
	statusNum: CONST.REPORT.STATUS_NUM.SUBMITTED,
	};
	}

What changes do you think we should make in order to solve the problem?

Modify getExpenseReportStateAndStatus to always return OPEN/OPEN when isEmptyOptimisticReport is true, before checking instant submit settings. This ensures empty reports start as OPEN, allowing expenses to be added immediately. It aligns with the backend’s behavior and fixes the button visibility when creating reports offline with instant submission enabled.

App/src/libs/ReportUtils.ts

Lines 6821 to 6822 in 3c5a961

	}
	const isInstantSubmitEnabledLocal = isInstantSubmitEnabled(policy);

 if (isASAPSubmitBetaEnabled) {
        return {
            stateNum: CONST.REPORT.STATE_NUM.OPEN,
            statusNum: CONST.REPORT.STATUS_NUM.OPEN,
        };
    }
    
    // Empty reports should always start as OPEN to allow adding expenses, even when instant submit is enabled
    if (isEmptyOptimisticReport) {
        return {
            stateNum: CONST.REPORT.STATE_NUM.OPEN,
            statusNum: CONST.REPORT.STATUS_NUM.OPEN,
        };
    }

What alternative solutions did you explore? (Optional)