Expense - Total paid appears duplicated when creating expense to McTest offline

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.67-10
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #76552
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: iOS
App Component: Other

Action Performed:

1. Open Expensify with a new account with no expenses
2. Tap to the "Reports" tab
3. Go offline
4. Click on "Create expense"
5. Tap on "Manual"
6. Add an amount and tap on "Next"
7. In Choose recipient page, select "Manager McTest"
8. Create and open the expense

Expected Result:

Only one marked as paid system message should appear.

Actual Result:

Marked as paid system message appears duplicated after creating the expense.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Marked as paid system message appears duplicated after creating the expense.

What is the root cause of that problem?

When first opening the expense report, we render some top report actions and hide the full report actions list:

App/src/pages/home/report/ReportActionsList.tsx

Line 206 in 938fac5

const [shouldScrollToEndAfterLayout, setShouldScrollToEndAfterLayout] = useState(shouldFocusToTopOnMount && !reportActionID);

App/src/pages/home/report/ReportActionsList.tsx

Line 861 in 938fac5

{shouldScrollToEndAfterLayout && topReportAction ? renderTopReportActions() : undefined}

App/src/pages/home/report/ReportActionsList.tsx

Line 872 in 938fac5

shouldScrollToEndAfterLayout ? styles.visibilityHidden : styles.visibilityVisible,

However, this implementation only works in Web, because visibility: hidden is not supported on Native environment.

So we see 2 actions displayed: 1 in renderTopReportActions and 1 in InvertedFlatList.

What changes do you think we should make in order to solve the problem?

We can add styles.opacity0 here for native environment:

shouldScrollToEndAfterLayout ? [styles.visibilityHidden, styles.opacity0] : styles.visibilityVisible,

App/src/pages/home/report/ReportActionsList.tsx

Line 872 in 938fac5

shouldScrollToEndAfterLayout ? styles.visibilityHidden : styles.visibilityVisible,

Or we can pass empty data to list if shouldScrollToEndAfterLayout is true.

data={shouldScrollToEndAfterLayout ? [] : sortedVisibleReportActions}

App/src/pages/home/report/ReportActionsList.tsx

Line 867 in 938fac5

data={sortedVisibleReportActions}

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[aimane-chnaif]

Dupe of #75986

[sakluger]

Closing as dupe