[Due for payment 2026-01-05] [$250] Reports - Workspace name in search input, changes to a code when member is removed.

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.63-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-2155/folder/13176922/47701683/1035950960
Email or phone of affected tester (no customers): ibellicotest+2113@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 / Android 12 / Chrome ( mWeb / Hybrid app) - Windows 11 / Chrome
App Component: Search

Action Performed:

Prerequisite: Have two accounts opened on two different devices or environments.
Prerequisite 2: User A has at least one workspace created.

1. Open the Expensify app.
2. Open any workspace chat.
3. Mention User B and select "Invite to submit expenses" on whisper.
4. As User B, navigate to "Reports"
5. Clear search input and type "Workspace:"
6. Select workspace from User A, on suggestions and trigger the search.
7. As User A, remove User B from workspace.
8. As User B, note that search is still triggered, but workspace name on search input is changed to a code with numbers and letters.

Expected Result:

When member of a workspace is removed after triggering a search filtering by workspace, the name of the workspace on search input, should remain the same and a "No results" screen should be visible, as workspace is no longer existent on account.

Actual Result:

When member of a workspace is removed after triggering a search filtering by workspace, the name of the workspace on search input, is changed to a code with numbers and letters.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug7012590_1764027538103.Code.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021993803899888082154
• Upwork Job ID: 1993803899888082154
• Last Price Increase: 2025-11-26

Issue Owner

Current Issue Owner: @lydiabarclay

[melvin-bot]

Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[TaduJR]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user is removed from a workspace while viewing search results filtered by that workspace, the workspace name in the search input changes from a human-readable name

What is the root cause of that problem?

When a user is removed from a workspace, the policy is removed from their Onyx ONYXKEYS.COLLECTION.POLICY store. The search display functions buildUserReadableQueryString and getFilterDisplayValue only look up workspace names from the live policies collection:

App/src/libs/SearchQueryUtils.ts

Lines 952 to 954 in f542fba

	if (filterName === CONST.SEARCH.SYNTAX_FILTER_KEYS.POLICY_ID) {
	return policies?.[`${ONYXKEYS.COLLECTION.POLICY}${filterValue}`]?.name ?? filterValue;
	}

App/src/libs/SearchQueryUtils.ts

Lines 985 to 987 in f542fba

	if (policyID && policyID.length > 0) {
	title += ` workspace:${policyID.map((id) => sanitizeSearchValue(policies?.[`${ONYXKEYS.COLLECTION.POLICY}${id}`]?.name ?? id)).join(',')}`;
	}

When the policy no longer exists, the fallback ?? filterValue / ?? id returns the raw policy ID instead of a cached name.

The codebase already handles this pattern elsewhere using oldPolicyName on reports:

App/src/libs/ReportUtils.ts

Lines 1349 to 1372 in f542fba

	function getPolicyName({report, returnEmptyIfNotFound = false, policy, policies, reports}: GetPolicyNameParams): string {
	const noPolicyFound = returnEmptyIfNotFound ? '' : unavailableTranslation;
	const parentReport = report ? getRootParentReport({report, reports}) : undefined;
	if (isEmptyObject(report) || (isEmptyObject(policies) && isEmptyObject(allPolicies) && !report?.policyName && !parentReport?.policyName)) {
	return noPolicyFound;
	}
	const finalPolicy = (() => {
	if (isEmptyObject(policy)) {
	if (policies) {
	return policies.find((p) => p.id === report.policyID);
	}
	return allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${report.policyID}`];
	}
	return policy ?? policies?.find((p) => p.id === report.policyID);
	})();
	// Rooms send back the policy name with the reportSummary,
	// since they can also be accessed by people who aren't in the workspace
	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	const policyName = finalPolicy?.name || report?.policyName || report?.oldPolicyName || parentReport?.policyName || parentReport?.oldPolicyName || noPolicyFound;
	return policyName;
	}

What changes do you think we should make in order to solve the problem?

Modify getFilterDisplayValue in SearchQueryUtils.ts to use the existing getPolicyName fallback chain from ReportUtils when the policy is not found in the live collection. This leverages the cached policyName and oldPolicyName fields already stored on reports.

Change in src/libs/SearchQueryUtils.ts:

// Before:
if (filterName === CONST.SEARCH.SYNTAX_FILTER_KEYS.POLICY_ID) {
    return policies?.[`${ONYXKEYS.COLLECTION.POLICY}${filterValue}`]?.name ?? filterValue;
}

// After:
if (filterName === CONST.SEARCH.SYNTAX_FILTER_KEYS.POLICY_ID) {
    const policyKey = `${ONYXKEYS.COLLECTION.POLICY}${filterValue}`;
    const policy = policies?.[policyKey];
    if (policy?.name) {
        return policy.name;
    }
    // Fallback: find cached name from reports that reference this policy
    const reportWithPolicyName = Object.values(reports ?? {}).find(
        (report) => report?.policyID === filterValue && (report?.policyName || report?.oldPolicyName)
    );
    return reportWithPolicyName?.policyName || reportWithPolicyName?.oldPolicyName || filterValue;
}

Similarly update the workspace name resolution in buildUserReadableQueryString:

// Before:
if (policyID && policyID.length > 0) {
    title += ` workspace:${policyID.map((id) => sanitizeSearchValue(policies?.[`${ONYXKEYS.COLLECTION.POLICY}${id}`]?.name ?? id)).join(',')}`;
}

// After:
if (policyID && policyID.length > 0) {
    title += ` workspace:${policyID.map((id) => {
        const policyKey = `${ONYXKEYS.COLLECTION.POLICY}${id}`;
        const policy = policies?.[policyKey];
        if (policy?.name) {
            return sanitizeSearchValue(policy.name);
        }
        const reportWithPolicyName = Object.values(reports ?? {}).find(
            (report) => report?.policyID === id && (report?.policyName || report?.oldPolicyName)
        );
        return sanitizeSearchValue(reportWithPolicyName?.policyName || reportWithPolicyName?.oldPolicyName || id);
    }).join(',')}`;
}

What alternative solutions did you explore? (Optional)

1. Create a new Onyx key for workspace name cache - Would require schema changes and additional storage management.
2. Store workspace name in the URL/query - Would require changes to the search query structure and parsing logic.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021993803899888082154

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[TaduJR]

Hey @hungvu193

What do you think of my Proposal?

Thanks!

[hungvu193]

Hey @hungvu193

What do you think of my Proposal?

Thanks!

Hi there, Sorry for the delay. I was OOO, I'll be back tmr and will review after that.