Skip to content

[$250] Use correct loading indicator in AddressSearch component #75535

Description

@mateuuszzzzz

Details

AddressSearch uses FullscreenLoadingIndicator, but it is not necessarily rendered fullscreen. With our recent changes to FullscreenLoadingIndicator which now renders a back button after 10 seconds to provide a recovery path in case of infinite loading, using this component on non-fullscreen pages could lead to a confusing UI, since those pages either aren’t fullscreen or already have their own navigation options. That’s why the Back Button feature is currently disabled by default.

We should change the component to ActivityIndicator while keeping the current design.

List of components to change:

  • src/components/AddressSearch/index.tsx

Parent issue: #69850, summary comment

Example of the FullscreenLoadingIndicator component:

Image
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021993085961614627528
  • Upwork Job ID: 1993085961614627528
  • Last Price Increase: 2025-11-24
  • Automatic offers:
    • PiyushChandra17 | Contributor | 109591911
Issue OwnerCurrent Issue Owner: @dylanexpensify

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.MonthlyKSv2ReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions