[Due for payment 2026-01-06] [$250] Desktop - Money Requests - Location permission denied leaves Setting button infinite loading

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.59-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to validate in Prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: N/A
Email or phone of affected tester (no customers): jsat+todo@applausemail.com
Issue reported by: Applause Internal Team
Device used: Macbook Pro/iOS 13.7.8
App Component: Money Requests

Action Performed:

Precondition: Location permission DISABLED / Location feature OFF

1. Login macOS Expensify App with valid credentials
2. Click on "FAB" button.
3. Click on "Create expense"
4. Click on "Scan" option
5. Choose a file
6. Choose any recipient
7. Click on "Create expense"
8. Click on "Settings" button on location modal
9. Close native settings without allowing location permission

Expected Result:

After closing native settings without allowing location permission, the "Settings" button should appear enable to click again.

Actual Result:

After closing native settings without allowing location permission, the "Settings" button remains stuck with an infinite loading spinner and cannot be accessed.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug7006865_1763422179538.InfiniteLoadingButtonAfterCloseNativeSettings.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021993450791123591806
• Upwork Job ID: 1993450791123591806
• Last Price Increase: 2025-12-04
• Automatic offers:
• situchan | Contributor | 109761246
• apeyada | Contributor | 109795947

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @CortneyOfstad

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dmkt9]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After closing native settings without allowing location permission, the "Settings" button remains stuck with an infinite loading spinner and cannot be accessed.

What is the root cause of that problem?

When the user clicks the Settings button, the app enters a loading state.

App/src/components/LocationPermissionModal/index.desktop.tsx

Line 73 in f34c0e3

setIsLoading(true);

However, since the default permission is not granted, the hasError value remains true, and the function returns early — causing the loading state to never be resolved.

App/src/components/LocationPermissionModal/index.desktop.tsx

Lines 72 to 79 in f34c0e3

	const handledBlockedPermission = (cb: () => void) => () => {
	setIsLoading(true);
	if (hasError) {
	window.electron.invoke(ELECTRON_EVENTS.OPEN_LOCATION_SETTING);
	return;
	}
	cb();
	};

What changes do you think we should make in order to solve the problem?

1. Move setIsLoading(true); below the if check.

App/src/components/LocationPermissionModal/index.desktop.tsx

Lines 72 to 79 in f34c0e3

	const handledBlockedPermission = (cb: () => void) => () => {
	setIsLoading(true);
	if (hasError) {
	window.electron.invoke(ELECTRON_EVENTS.OPEN_LOCATION_SETTING);
	return;
	}
	cb();
	};

     const handledBlockedPermission = (cb: () => void) => () => {
-        setIsLoading(true);
         if (hasError) {
             window.electron.invoke(ELECTRON_EVENTS.OPEN_LOCATION_SETTING);
             return;
         }
+        setIsLoading(true);
         cb();
     };

2. Add setHasError to automatically switch from Settings to Continue button if the user grants permission.
   

   App/src/components/LocationPermissionModal/index.desktop.tsx

   Lines 25 to 32 in f34c0e3

   	const checkPermission = useCallback(() => {
   	getLocationPermission().then((status) => {
   	if (status !== RESULTS.GRANTED && status !== RESULTS.LIMITED) {
   	return;
   	}
   	onGrant();
   	});
   	}, [onGrant]);

     const checkPermission = useCallback(() => {
         getLocationPermission().then((status) => {
             if (status !== RESULTS.GRANTED && status !== RESULTS.LIMITED) {
+                setHasError(true);
                 return;
             }
+            setHasError(false);
             onGrant();
         });
     }, [onGrant]);

What alternative solutions did you explore? (Optional)

Clear the loading state when the user returns to the app or when timeout === CONST.GPS.TIMEOUT.

App/src/components/LocationPermissionModal/index.desktop.tsx

Lines 74 to 77 in f34c0e3

	if (hasError) {
	window.electron.invoke(ELECTRON_EVENTS.OPEN_LOCATION_SETTING);
	return;
	}

         if (hasError) {
             window.electron.invoke(ELECTRON_EVENTS.OPEN_LOCATION_SETTING);
+            shouldClearLoadingRef.current = true;
             return;
         }

App/src/components/LocationPermissionModal/index.desktop.tsx

Lines 41 to 43 in f34c0e3

	const unsubscribe = Visibility.onVisibilityChange(() => {
	debouncedCheckPermission();
	});

         const unsubscribe = Visibility.onVisibilityChange(() => {
             debouncedCheckPermission();
+            if (shouldClearLoadingRef.current && Visibility.isVisible()) {
+                shouldClearLoadingRef.current = false;
+                setIsLoading(false);
+            }
         });

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021993450791123591806

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

[CortneyOfstad]

Hey @ahmedGaber93! There is a proposal above for you to review – thank you!