[Awaiting Payment][$250] Expense - Flip option is shown in confirmation page in amount section.

@sakluger

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: V9.2.59-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1995/folder/13176670/41237103/1016710067
Email or phone of affected tester (no customers): Slottwo1 l@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: Money Requests

Action Performed:

Go to https://staging.new.expensify.com/home
Tap Fab - Create expense
Enter an amount
Tap next
Select a 1:1 user
Tap amount and tap flip and change amount to negative
Tap create expense
Open the expense
Tap amount
Note expense created is not negative

Expected Result:

In step 6, flip option must not be shown in confirmation page in amount section.

Actual Result:

In step 6, flip option is shown in confirmation page in amount section.

Workaround:

Unknown

Platforms:

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021990456907474787796
Upwork Job ID: 1990456907474787796
Last Price Increase: 2025-11-17

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @sakluger

@sakluger

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

🚨 Edited by proposal-police: This proposal was edited at 2025-11-18 15:02:53 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

In step 6, flip option is shown in confirmation page in amount section.

What is the root cause of that problem?

Whether the "Flip" button is allowed to be displayed depends on the allowNegative flag:

App/src/pages/iou/request/step/IOURequestStepAmount.tsx

Line 103 in ca4289f

const allowNegative = shouldEnableNegative(report, policy, iouType);
When the recipient is a user who hasn’t been chatted with before, the chat report for that user will be undefined, so isFirstTimeCreatingReport will be true:

App/src/libs/ReportUtils.ts

Line 1916 in f34c0e3

const isFirstTimeCreatingReport = !report && !policy && iouType === CONST.IOU.TYPE.SUBMIT;

As a result, allowNegative will be set to true.

What changes do you think we should make in order to solve the problem?

For isFirstTimeCreatingReport, we need to add a condition to check the recipients.
If the recipients include a user, then isFirstTimeCreatingReport should be false.

App/src/libs/ReportUtils.ts

Lines 1914 to 1916 in f34c0e3

    
           function shouldEnableNegative(report: OnyxEntry<Report>, policy?: OnyxEntry<Policy>, iouType?: string) { 
        
               const isSelfDMReport = isSelfDMOrSelfDMThread(report); 
        
               const isFirstTimeCreatingReport = !report && !policy && iouType === CONST.IOU.TYPE.SUBMIT;

function shouldEnableNegative(report: OnyxEntry<Report>, policy?: OnyxEntry<Policy>, iouType?: string, participants?: Participant[]) {
    const isSelfDMReport = isSelfDMOrSelfDMThread(report);

    const isUserInRecipients = participants && participants.some((participant) => !participant.isSender && !participant.isPolicyExpenseChat && participant.accountID);
    const isFirstTimeCreatingReport = !report && !policy && iouType === CONST.IOU.TYPE.SUBMIT && !isUserInRecipients;

App/src/pages/iou/request/step/IOURequestStepAmount.tsx

Line 102 in f34c0e3

const allowNegative = shouldEnableNegative(report, policy, iouType);

const allowNegative = shouldEnableNegative(report, policy, iouType, transaction?.participants);

What alternative solutions did you explore? (Optional)

N/A

Job added to Upwork: https://www.upwork.com/jobs/~021990456907474787796

@shubham1206agra

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

The amount “Flip” control appears in confirmation's edit amount for 1:1 DMs, allowing negative expenses there.

What is the root cause of that problem?

The amount step always enables flipping whenever negatives are allowed and the flow is not a split, without excluding direct messages. There is no DM check guarding allowFlippingAmount, so the Flip button shows even in DM contexts.

App/src/pages/iou/request/step/IOURequestStepAmount.tsx

Lines 101 to 107 in 4c1d026

    
           const isEditingSplitBill = isEditing && isSplitBill; 
        
           const currentTransaction = isEditingSplitBill && !isEmptyObject(splitDraftTransaction) ? splitDraftTransaction : transaction; 
        
           const allowNegative = shouldEnableNegative(report, policy, iouType); 
        
           const disableOppositeConversion = isCreateAction || (isSubmitType && isSubmitAction); 
        
           const {amount: transactionAmount} = getTransactionDetails(currentTransaction, undefined, undefined, allowNegative, disableOppositeConversion) ?? {amount: 0}; 
        
           const {currency: originalCurrency} = getTransactionDetails(isEditing && !isEmptyObject(draftTransaction) ? draftTransaction : transaction) ?? {currency: CONST.CURRENCY.USD}; 
        
           const currency = isValidCurrencyCode(selectedCurrency) ? selectedCurrency : originalCurrency;

What changes do you think we should make in order to solve the problem?

Add a DM guard before enabling Flip on the amount step so the control stays hidden in 1:1 chats, while still showing for self DMs (where negatives are allowed) and for workspace recipients/other allowed flows.

Updated code:

const isEditingSplitBill = isEditing && isSplitBill;
const currentTransaction = isEditingSplitBill && !isEmptyObject(splitDraftTransaction) ? splitDraftTransaction : transaction;
const allowNegative = shouldEnableNegative(report, policy, iouType);
const disableOppositeConversion = isCreateAction || (isSubmitType && isSubmitAction);
const {amount: transactionAmount} = getTransactionDetails(currentTransaction, undefined, undefined, allowNegative, disableOppositeConversion) ?? {amount: 0};
const {currency: originalCurrency} = getTransactionDetails(isEditing && !isEmptyObject(draftTransaction) ? draftTransaction : transaction) ?? {currency: CONST.CURRENCY.USD};
const currency = isValidCurrencyCode(selectedCurrency) ? selectedCurrency : originalCurrency;
const shouldAllowFlippingAmount = !isSplitBill && allowNegative && (!isDM(report) || isSelfDM(report));

By refering the Expected result and video attached in the issue description, I didn't get what do we actually need in final result?
Do we need to remove the flip button on the manual amount section?
My proposal is ready but I need some clarification about the issue and final result.

@dmkt9

Payment Summary

Contributor: @dmkt9 due $250 via Upwork: Sent offer (https://www.upwork.com/nx/wm/offer/109904759)
Contributor+: @shubham1206agra due $250 via Newdot

@shubham1206agra

@shubham1206agra do we need any new or updated regression tests for this one?

Test -

Open App
Tap Fab - Create expense
Enter an amount
Tap "Next"
Select a 1:1 user who hasn't been chatted with yet
Tap "Amount"
Verify that the flip option must not be shown in the confirmation page in the amount section.

@sakluger

@sakluger Thank you. Payment requested.

@sakluger

@sakluger Whoops! This issue is 2 days overdue. Let's get this updated quick!

@sakluger

@sakluger Whoops! This issue is 2 days overdue. Let's get this updated quick!

@dmkt9

Thanks @dmkt9, I completed the payment.

@shubham1206agra

$250 approved for @shubham1206agra

Navigation Menu

Repository navigation

[Awaiting Payment][$250] Expense - Flip option is shown in confirmation page in amount section. #75304

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

27 remaining items

Payment Summary

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	function shouldEnableNegative(report: OnyxEntry<Report>, policy?: OnyxEntry<Policy>, iouType?: string) {
	const isSelfDMReport = isSelfDMOrSelfDMThread(report);
	const isFirstTimeCreatingReport = !report && !policy && iouType === CONST.IOU.TYPE.SUBMIT;

	const isEditingSplitBill = isEditing && isSplitBill;
	const currentTransaction = isEditingSplitBill && !isEmptyObject(splitDraftTransaction) ? splitDraftTransaction : transaction;
	const allowNegative = shouldEnableNegative(report, policy, iouType);
	const disableOppositeConversion = isCreateAction \|\| (isSubmitType && isSubmitAction);
	const {amount: transactionAmount} = getTransactionDetails(currentTransaction, undefined, undefined, allowNegative, disableOppositeConversion) ?? {amount: 0};
	const {currency: originalCurrency} = getTransactionDetails(isEditing && !isEmptyObject(draftTransaction) ? draftTransaction : transaction) ?? {currency: CONST.CURRENCY.USD};
	const currency = isValidCurrencyCode(selectedCurrency) ? selectedCurrency : originalCurrency;

[Awaiting Payment][$250] Expense - Flip option is shown in confirmation page in amount section. #75304

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Nov 17, 2025

dmkt9 commented on Nov 17, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Nov 17, 2025

melvin-bot commented on Nov 17, 2025

ShridharGoel commented on Nov 17, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Uzaifm127 commented on Nov 17, 2025

shubham1206agra commented on Nov 18, 2025

27 remaining items

sakluger commented on Dec 23, 2025

Payment Summary

sakluger commented on Dec 23, 2025

shubham1206agra commented on Dec 23, 2025

dmkt9 commented on Dec 23, 2025

melvin-bot commented on Dec 27, 2025

melvin-bot commented on Jan 1, 2026

sakluger commented on Jan 5, 2026

garrettmknight commented on Apr 2, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions