[$250] Wallet - Card details are not hidden when revealing card details and reopening card details

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.58-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1965/folder/13176890/47403243/1013856465
Email or phone of affected tester (no customers): applausetester+141102kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• User has a virtual card.

1. Go to staging.new.expensify.com
2. Go to Account > Wallet.
3. Click on the virtual card.
4. Click Reveal details.
5. Enter magic code.
6. Close card details RHP.
7. Click on the same virtual card.
   → Card details are no longer revealed on RHP after reopening card details RHP - Expected.
8. Click Reveal details.
9. Enter magic code.
10. Click View transactions.
11. Go to Account > Wallet.
12. Click on the same virtual card.

Expected Result:

Card details will no longer be revealed on RHP after viewing transactions and reopening card details RHP,

Actual Result:

Card details are still revealed on RHP after viewing transactions and reopening card details RHP,

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021991093931223771631
• Upwork Job ID: 1991093931223771631
• Last Price Increase: 2025-11-19
• Automatic offers:
• samranahm | Contributor | 109603240

Issue Owner

Current Issue Owner: @MarioExpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Card details are not hidden when revealing card details and reopening card details

What is the root cause of that problem?

The ExpensifyCardPage component only used useBeforeRemove hook to clear revealed card details from context state. This hook only fires when the screen is removed from the navigation stack (e.g., closing the RHP).

However, when the user clicks "View transactions", the card details screen remains in the navigation stack and only loses focus. The useBeforeRemove hook doesn't fire in this scenario, so the card details remain in memory.

When the user returns to the card details page via "Account > Wallet > Card", the screen regains focus with the old card details still present in the context state, causing them to remain visible without re-authentication.

App/src/pages/settings/Wallet/ExpensifyCardPage/index.tsx

Lines 135 to 138 in 4242e34

	// This resets card details when we exit the page.
	useBeforeRemove(() => {
	setCardsDetails((oldCardDetails) => ({...oldCardDetails, [cardID]: null}));
	});

What changes do you think we should make in order to solve the problem?

we should use useFocusEffect to set cards details when screen regains focus

// Resets card details when the screen regains focus after navigating away
useFocusEffect(
    useCallback(() => {
        return () => {
            setCardsDetails((oldCardDetails) => ({...oldCardDetails, [cardID]: null}));
        };
    }, [cardID, setCardsDetails]),
);

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021991093931223771631

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

[ikevin127]

♻️ Currently out of town - will be reviewing the proposals next week on monday, if this is urgent and needs addressed asap feel free to re-assign reviewer, thanks!