[Due for payment 2026-01-21] [$125] QAB - Add receipt from manual expense, QAB is scan receipt but confirm detail display as manual

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.49-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Explore
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Win 11/Chrome
App Component: Money Requests

Action Performed:

1. Open https://staging.new.expensify.com
2. Navigate to any workspace chat
3. Create a manual expense to step Confirm details
4. Fill merchant and select category
5. Click on "+" button and add a receipt
6. Click on Create expense
7. Click on FAB
8. Select Scan receipt at Quick action
9. Add a receipt and observe Confirm details page

Expected Result:

QAB should display Create expense or if QAB display Scan receipt, Confirm detail page should show Confirm details of scan expense

Actual Result:

QAB displays Scan receipt but Confirm details page as manual expense, user has to type merchant field for create expense

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021989469466369597185
• Upwork Job ID: 1989469466369597185
• Last Price Increase: 2025-12-18

Issue Owner

Current Issue Owner: @lydiabarclay

[melvin-bot]

Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

QAB displays Scan receipt but Confirm details page as manual expense, user has to type merchant field for create expense

What is the root cause of that problem?

After creating an manual expense with receipt, the backend returns the quick action as scan action. Because the last selected tab is manual, the tab is changed to scan which triggered resetIOUTypeIfChanged

App/src/pages/iou/request/IOURequestStartPage.tsx

Line 150 in 82a45ab

const resetIOUTypeIfChanged = useCallback(

After that this useFocusEffect also triggers resetIOUTypeIfChanged but transactionRequestType is manual because the transaction is not merged completely. Then the iouRequestType of transaction is manual which causes this issue.

App/src/pages/iou/request/IOURequestStartPage.tsx

Lines 176 to 179 in 82a45ab

	if (transaction?.reportID === reportID || isLoadingSelectedTab || !transactionRequestType || prevTransactionReportID !== transaction?.reportID) {
	return;
	}
	resetIOUTypeIfChanged(transactionRequestType);

What changes do you think we should make in order to solve the problem?

When the tab is changed, selectedTab from Onyx data can't update immediately then we can create a state to store the selectedTab. With this useFocusEffect can be one more time with the correct type because transactionRequestType is changed.

const [lastSelectedTab, selectedTabResult] = useOnyx(`${ONYXKEYS.COLLECTION.SELECTED_TAB}${CONST.TAB.IOU_REQUEST_TYPE}`, {canBeMissing: true});
const [selectedTab, setSelectedTab] = useState(lastSelectedTab);
onTabSelected={(newIouType) => {
                                    setSelectedTab(newIouType);
                                    resetIOUTypeIfChanged(newIouType);
                                }}

What alternative solutions did you explore? (Optional)

When the tab is changed, we can store the selected tab to a ref

App/src/pages/iou/request/IOURequestStartPage.tsx

Line 252 in 82a45ab

onTabSelected={resetIOUTypeIfChanged}

And skip the useFocusEffect if the ref value is different from transactionRequestType.

This approach can prevent resetIOUTypeIfChanged is called from this useEffect with the outdated iouRequestType

useLayoutEffect(() => {
        lastIouRequestTypeRef.current = transactionRequestType;
    }, [transactionRequestType])

    // Clear out the temporary expense if the reportID in the URL has changed from the transaction's reportID.
    useFocusEffect(
        useCallback(() => {
            // The test transaction can change the reportID of the transaction on the flow so we should prevent the reportID from being reverted again.
            if (!transactionRequestType || transaction?.reportID === reportID || isLoadingSelectedTab || lastIouRequestTypeRef.current !== transactionRequestType || prevTransactionReportID !== transaction?.reportID) {
                return;
            }
            resetIOUTypeIfChanged(transactionRequestType);
        }, [transaction?.reportID, reportID, resetIOUTypeIfChanged, isLoadingSelectedTab, prevTransactionReportID, transactionRequestType]),
    );

onTabSelected={(newIouType) => {
                                    lastIouRequestTypeRef.current = newIouType;
                                    resetIOUTypeIfChanged(newIouType);
                                }}

App/src/pages/iou/request/IOURequestStartPage.tsx

Lines 176 to 179 in 82a45ab

	if (transaction?.reportID === reportID || isLoadingSelectedTab || !transactionRequestType || prevTransactionReportID !== transaction?.reportID) {
	return;
	}
	resetIOUTypeIfChanged(transactionRequestType);

Another approach is change useFocusEffect to useLayoutEffect which will trigger before onTabSelected event then the current iouRequestType can be updated later

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021989469466369597185

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)