[Due for Payment 12/23][$250] Report field - Disabled list-type report fields remain visible in the expense report

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.49-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exp + https://test-management.browserstack.com/projects/2219752/test-runs/TR-1933/folder/13176707/41236876/1008199851?sort=-identifier
Email or phone of affected tester (no customers): biruknew45+66dd55tsdlhhj@gmail.com
Issue reported by: Applause Internal Team
Device used: Web, mweb, android
App Component: Workspace Settings

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Create a Workspace
3. Create a list-type report field with one list value and set the initial value
4. Go to the WS chat and create a report
5. Open the report, and the list-type report field appears
6. Go to WS settings, then disable the report fields feature and re-enable it
7. Check that list values are disabled
8. Navigate to the WS chat and open the report

Expected Result:

When the list values are disabled, they should not appear in the expense report.

Actual Result:

After toggling the report fields feature off and on, the list-type report field remains visible in the expense report even though its list values are disabled.

If the list value is disabled directly (without disabling and re-enabling the report fields feature), the field disappears correctly from the expense report.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug7000810_1762882005624.bandicam_2025-11-11_20-05-53-843.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021990522102565444250
• Upwork Job ID: 1990522102565444250
• Last Price Increase: 2025-12-01
• Automatic offers:
• mkzie2 | Contributor | 109697065

Issue Owner

Current Issue Owner: @neil-marcellini

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After toggling the report fields feature off and on, the list-type report field remains visible in the expense report even though its list values are disabled.

What is the root cause of that problem?

We don't check the report field value when it's disabled here

App/src/components/MoneyRequestReportView/MoneyRequestViewReportFields.tsx

Lines 96 to 106 in 82a45ab

	.map((field): EnrichedPolicyReportField => {
	const fieldValue = field.value ?? field.defaultValue;
	const isFieldDisabled = isReportFieldDisabled(report, field, policy);
	const fieldKey = getReportFieldKey(field.fieldID);
	const violation = getFieldViolation(violations, field);
	const violationTranslation = getFieldViolationTranslation(field, violation);
	return {
	...field,
	fieldValue,

What changes do you think we should make in order to solve the problem?

If the field type is list and the current value is disabled, we should show the value as an empty string.

            .map((field): EnrichedPolicyReportField => {
                let fieldValue = field.value ?? field.defaultValue;
                if(field.type === CONST.REPORT_FIELD_TYPES.LIST) {
                    const index = field.values.findIndex((value) => value === fieldValue);
                    fieldValue = field.disabledOptions.at(index) ? '' : fieldValue;
                }

App/src/components/MoneyRequestReportView/MoneyRequestViewReportFields.tsx

Lines 96 to 106 in 82a45ab

	.map((field): EnrichedPolicyReportField => {
	const fieldValue = field.value ?? field.defaultValue;
	const isFieldDisabled = isReportFieldDisabled(report, field, policy);
	const fieldKey = getReportFieldKey(field.fieldID);
	const violation = getFieldViolation(violations, field);
	const violationTranslation = getFieldViolationTranslation(field, violation);
	return {
	...field,
	fieldValue,

then we should apply the same logic in getReportFieldOptionsSection function

Note 1: We can do the same with another type if needed
Note 2: We can add a condition that if the list does not have any enabled items, we can hide that field.

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After toggling the report fields feature off and on, the list-type report field remains visible in the expense report even though its list values are disabled.

What is the root cause of that problem?

1. When users update the report fields, we just update the fieldList in policy, but we also have fieldList in report, and we're using fieldList in report to display the report fields

2. We already have the logic to hide the single report field in

App/src/components/ReportActionItem/MoneyReportView.tsx

Lines 104 to 109 in 82a45ab

	const shouldHideSingleReportField = (reportField: PolicyReportField) => {
	const fieldValue = reportField.value ?? reportField.defaultValue;
	const hasEnableOption = reportField.type !== CONST.REPORT_FIELD_TYPES.LIST || reportField.disabledOptions.some((option) => !option);
	return isReportFieldOfTypeTitle(reportField) || (!fieldValue && !hasEnableOption);
	};

but fieldValue has not been clear yet, so we still display it.

What changes do you think we should make in order to solve the problem?

1. To get the up-to-date fieldList in report, we have 2 approaches:

Approach 1: Override the disabledOptions, values in getAvailableReportFields

const policyReportField = policyReportFields.find(({fieldID}) => fieldID === id);
...
        if (field) {
            return {
                ...field,
                ...(policyReportField && {
                    disabledOptions: policyReportField.disabledOptions,
                    values: policyReportField.values,
                }),
            };
        }
...

Approach 2: Update the filedList for all reports when calling updateReportFieldListValueEnabled

App/src/libs/actions/Policy/ReportField.ts

Line 409 in 82a45ab

function updateReportFieldListValueEnabled({policy, reportFieldID, valueIndexes, enabled}: UpdateReportFieldListValueEnabledParams) {

optimistically

2. Even when the data is correct, we still need to update shouldHideSingleReportField, so the field with all disabled options will be hidden

    const shouldHideSingleReportField = (reportField: PolicyReportField) => {
        const hasEnableOption = reportField.type !== CONST.REPORT_FIELD_TYPES.LIST || reportField.disabledOptions.some((option) => !option);

        return isReportFieldOfTypeTitle(reportField) || !hasEnableOption;
    };

What alternative solutions did you explore? (Optional)

Currently, we don't hide the disabled item in the selector, so we can consider hiding them as well.
Or we can reset the value to empty when all items are disabled.

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[CortneyOfstad]

Getting eyes

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021990522102565444250